Fix the unconditional usage of string interpolation in strum #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tronical
added a commit
to slint-ui/slint
that referenced
this pull request
Jun 3, 2024
Patch in Peternator7/strum#360 until it is merged and released on crates.io.
gmryuuko
reviewed
Jun 26, 2024
| @@ -124,7 +124,17 @@ pub fn display_inner(ast: &DeriveInput) -> syn::Result<TokenStream> { | |||
| } | |||
| } | |||
| } | |||
| Fields::Unit => quote! { #name::#ident #params => ::core::fmt::Display::fmt(&format!(#output), f) } | |||
| Fields::Unit => { | |||
There was a problem hiding this comment.
Related to #363
Since format! is no longer used for Unit, please do not check the curly brackets on it.
This will cause the use of a single curly bracket to fail to compile, and two curly brackets cannot be escaped.
Or continue to use format! for Unit, and release it as a breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #359