Skip to content

Update FormatUtil.java #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2021
Merged

Update FormatUtil.java #107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/main/java/net/jacobpeterson/alpaca/util/format/FormatUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,6 @@ public class FormatUtil {
// the 3rd and 4th least significant decimal digits.
private static final NumberFormat CURRENCY_FORMATTER = new DecimalFormat("#0.00##",
DecimalFormatSymbols.getInstance(Locale.US));
private static final DateTimeFormatter RFC_3339_FORMATTER =
DateTimeFormatter.ofPattern("yyyy-MM-dd'T'HH:mm:ss'Z'").withZone(NEW_YORK_ZONED_ID);

/**
* Formats an arbitrary number to a currency format. e.g. $123.45
*
Expand All @@ -37,13 +34,15 @@ public static String toCurrencyFormat(Number numberToFormat) {
}

/**
* Formats a {@link TemporalAccessor} using {@link #RFC_3339_FORMATTER} {@link DateTimeFormatter}.
* Formats a {@link TemporalAccessor} using {@link DateTimeFormatter#ISO_OFFSET_DATE_TIME}.
*
* @param zonedDateTime the {@link ZonedDateTime}
*
* @return the formatted string
*/
public static String toRFC3339Format(ZonedDateTime zonedDateTime) {
return RFC_3339_FORMATTER.format(zonedDateTime);
//Alpaca requires RFC 3339 (https://www.ietf.org/rfc/rfc3339.txt) date time to be provided which includes time zone.
// ISO 8601 is compatible with RFC 3339.
return DateTimeFormatter.ISO_OFFSET_DATE_TIME.format(zonedDateTime);
}
}