Feature/rng removed from settings #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add more tests for the random functions
As these tests will not always pass, performing tests can be confusing because they will often report a failed test even though there is nothing wrong. The running of the optimizers are kept to ensure that running the tests will still cover actual runtime errors from them.
Removed ability to set the RNG seed to be used in an optimizer. This was done because the RNG seed would only have the desired effect under very specific conditions: running an algorithm in serial mode on one specific system. Some algorithms will for some reason not give reproducible results even under this condition. **As the setting will in most cases just cause confusion, it has been removed**. Setting the RNGSeed field in a driver file will cause an error. The parameter field in the settings has been kept, as it is still useful in some unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed ability to set the RNG seed to be used in an optimizer.
This was done because the RNG seed would only have the desired effect
under very specific conditions: running an algorithm in serial mode on
one specific system. Some algorithms will for some reason not give
reproducible results even under this condition.
As the setting will in most cases just cause confusion, it has been
removed. Setting the RNGSeed field in a driver file will cause an
error.
The parameter field in the settings has been kept, as it is
still useful in some unit tests.
The relevant change is found in
Settings/optimizer.cpp.