feat:增加贴边半隐模式的支持 #161
Merged
feat:增加贴边半隐模式的支持 #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Petterpx
reviewed
Jun 30, 2024
| @@ -75,6 +75,17 @@ abstract class FxBasisControlImp<F : FxBasisHelper, P : IFxPlatformProvider<F>>( | |||
| } | |||
| } | |||
|
|
|||
| override fun halfHide(bSet: Boolean) { | |||
There was a problem hiding this comment.
谢谢作者回复，但这里用enable似乎不合适，enable是在config中去设置了是否支持半隐，所以在config中使用了override fun setEnableHalfHide(isEnable: Boolean)
但这里想表达的是一个切换控制，bSet表示在已经enable后，切换（也可以说开启和关闭）半隐和正常状态。
比如在列表滑动时set为true开启半隐，列表停止滑动是set为false，恢复正常状态。
| @@ -38,6 +38,10 @@ interface IFxConfigControl { | |||
| * */ | |||
| fun setEnableEdgeRebound(isEnable: Boolean) | |||
|
|
|||
| /** 启用边缘回弹 | |||
| private fun moveToXY(x: Float, y: Float, useAnimation: Boolean) { | ||
| val endX = locationHelper.safeX(x) | ||
| val endY = locationHelper.safeY(y) | ||
| private fun moveToXY(x: Float, y: Float, useAnimation: Boolean, safeCheck: Boolean = true) { |
There was a problem hiding this comment.
safeCheck的命名也有点怪，这里使用一个scene做type会更合理点
There was a problem hiding this comment.
这里添加这个参数是有以下几点考虑：
- 这里是一个private方法，内部调用moveToXY时区分不同的逻辑
- 您原代码中，获取x，y默认使用了safeX(), safeY(), 所以通过添加这个参数，在特殊情况下，不使用您默认函数的safe()方法，所以参数命名为safeCheck
docs: 设置是否支持悬浮窗半隐模式 fun setEnableHalfHide(isEnable: Boolean)
luckydzp
commented
Jul 3, 2024
| private fun moveToXY(x: Float, y: Float, useAnimation: Boolean) { | ||
| val endX = locationHelper.safeX(x) | ||
| val endY = locationHelper.safeY(y) | ||
| private fun moveToXY(x: Float, y: Float, useAnimation: Boolean, safeCheck: Boolean = true) { |
There was a problem hiding this comment.
这里添加这个参数是有以下几点考虑：
- 这里是一个private方法，内部调用moveToXY时区分不同的逻辑
- 您原代码中，获取x，y默认使用了safeX(), safeY(), 所以通过添加这个参数，在特殊情况下，不使用您默认函数的safe()方法，所以参数命名为safeCheck
| @@ -75,6 +75,17 @@ abstract class FxBasisControlImp<F : FxBasisHelper, P : IFxPlatformProvider<F>>( | |||
| } | |||
| } | |||
|
|
|||
| override fun halfHide(bSet: Boolean) { | |||
There was a problem hiding this comment.
谢谢作者回复，但这里用enable似乎不合适，enable是在config中去设置了是否支持半隐，所以在config中使用了override fun setEnableHalfHide(isEnable: Boolean)
但这里想表达的是一个切换控制，bSet表示在已经enable后，切换（也可以说开启和关闭）半隐和正常状态。
比如在列表滑动时set为true开启半隐，列表停止滑动是set为false，恢复正常状态。
|
@luckydzp 开源共建，cool ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.