fix: firelens configFileValue is optional

aws/aws-for-fluent-bit#352 Signed-off-by: Wesley Pettit <wppttt@amazon.com>
PettitWesley · May 18, 2022 · 39d588a · 39d588a
1 parent c50d60c
commit 39d588a
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/packages/@aws-cdk/aws-ecs/lib/firelens-log-router.ts b/packages/@aws-cdk/aws-ecs/lib/firelens-log-router.ts
@@ -61,7 +61,7 @@ export interface FirelensOptions {
   /**
    * Custom configuration file, S3 ARN or a file path
    */
-  readonly configFileValue: string;
+  readonly configFileValue?: string;
 }
 
 /**
@@ -203,7 +203,7 @@ export class FirelensLogRouter extends ContainerDefinition {
     if (options) {
       const enableECSLogMetadata = options.enableECSLogMetadata || options.enableECSLogMetadata === undefined;
       const configFileType = (options.configFileType === undefined || options.configFileType === FirelensConfigFileType.S3) &&
-        (cdk.Token.isUnresolved(options.configFileValue) || /arn:aws[a-zA-Z-]*:s3:::.+/.test(options.configFileValue))
+        (cdk.Token.isUnresolved(options.configFileValue) || /arn:aws[a-zA-Z-]*:s3:::.+/.test(options.configFileValue || ""))
         ? FirelensConfigFileType.S3 : FirelensConfigFileType.FILE;
       this.firelensConfig = {
         type: props.firelensConfig.type,
@@ -226,7 +226,7 @@ export class FirelensLogRouter extends ContainerDefinition {
           actions: [
             's3:GetBucketLocation',
           ],
-          resources: [options.configFileValue.split('/')[0]],
+          resources: [(options.configFileValue || "").split('/')[0]],
         }));
       }
     } else {