Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch length 'pt' calculation to use box #94

Closed
PgBiel opened this issue Dec 15, 2023 · 0 comments
Closed

Switch length 'pt' calculation to use box #94

PgBiel opened this issue Dec 15, 2023 · 0 comments
Assignees
@PgBiel
Labels
enhancement New feature or request
Milestone
v0.0.7

Comments

@PgBiel
Copy link
Owner

PgBiel commented Dec 15, 2023

Using measure(line(...)) is more susceptible to show rule problems; if box were to receive a problematic show rule, it's likely lots of other things would break in tablex anyway, so there isn't much we can do to guard against that.

See also cetz-package/cetz#346 for inspiration.
@PgBiel PgBiel added the enhancement New feature or request label Dec 15, 2023
@PgBiel PgBiel self-assigned this Dec 15, 2023
PgBiel added a commit that referenced this issue Dec 15, 2023
@PgBiel
utilities: use box to calculate 'pt' of a length
004bc9b 
Should be more robust.

Closes #94
@PgBiel PgBiel closed this as completed Dec 15, 2023
@PgBiel PgBiel added this to the v0.0.7 milestone Dec 15, 2023
PgBiel added a commit that referenced this issue Dec 15, 2023
@PgBiel
backport fix for #94
5d21680 
use box to calculate 'pt' of a length (more robust)
PgBiel added a commit that referenced this issue Dec 15, 2023
@PgBiel
add #94 to 0.0.7 changelog
af5e952
PgBiel added a commit that referenced this issue Dec 17, 2023
@PgBiel
utilities: use box to calculate 'pt' of a length
ad5121d 
Should be more robust.

Closes #94
PgBiel added a commit that referenced this issue Dec 18, 2023
@PgBiel
add #94 to 0.0.7 changelog
7993f88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PgBiel PgBiel

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.0.7
Development

No branches or pull requests
1 participant
@PgBiel