Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Polkadot v0.9.39 #1203

Merged
merged 9 commits into from
Mar 22, 2023
Merged

Upgrade to Polkadot v0.9.39 #1203

merged 9 commits into from
Mar 22, 2023

Conversation

jasl
Copy link
Collaborator

@jasl jasl commented Mar 14, 2023

paritytech/substrate@polkadot-v0.9.37...polkadot-v0.9.38
paritytech/substrate@polkadot-v0.9.38...polkadot-v0.9.39

Breaking changes from upstream:

Other notable changes:

Notes:
warning: the following packages contain code that will be rejected by a future version of Rust: nom v5.1.2
which dependent by https://github.com/http-rs/surf (used by phactory)
it seems 1 year no update, maybe we should replace it

---- runtime::tests::gas_limit_works stdout ----
thread 'runtime::tests::gas_limit_works' panicked at 'events not registered at the genesis block', /Users/jasl/.cargo/git/checkouts/substrate-7e08433d4c370a21/1837f42/frame/system/src/lib.rs:1440:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- runtime::__construct_runtime_integrity_test::runtime_integrity_tests stdout ----
thread 'runtime::__construct_runtime_integrity_test::runtime_integrity_tests' panicked at 'Given `CallStack` height 6, `MaxCodeLen` should be set less than 82526 (current value is 2097152), to avoid possible runtime oom issues.', /Users/jasl/.cargo/git/checkouts/substrate-7e08433d4c370a21/1837f42/frame/contracts/src/lib.rs:396:13

relates to https://github.com/paritytech/substrate/pull/12993/files#diff-70e9723e9db62816e35f6f885b6770a8449c75a6c2733e9fa7a245fe52c4656cR423-R437

In adiition:

@jasl jasl force-pushed the polkadot-v0.9.39 branch 3 times, most recently from 8f6182c to 5541b84 Compare March 17, 2023 01:18
@jasl jasl requested a review from kvinwang March 17, 2023 01:19
@jasl jasl force-pushed the polkadot-v0.9.39 branch from 5541b84 to 30d034e Compare March 17, 2023 01:40
@jasl jasl force-pushed the polkadot-v0.9.39 branch from 30d034e to 45fae7c Compare March 20, 2023 08:58
@kvinwang
Copy link
Collaborator

warning: the following packages contain code that will be rejected by a future version of Rust: nom v5.1.2
which dependent by https://github.com/http-rs/surf (used by phactory)

Removed.

---- runtime::tests::gas_limit_works stdout ----
thread 'runtime::tests::gas_limit_works' panicked at 'events not registered at the genesis block', /Users/jasl/.cargo/git/checkouts/substrate-7e08433d4c370a21/1837f42/frame/system/src/lib.rs:1440:9
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace

Fixed.

---- runtime::__construct_runtime_integrity_test::runtime_integrity_tests stdout ----
thread 'runtime::__construct_runtime_integrity_test::runtime_integrity_tests' panicked at 'Given CallStack height 6, MaxCodeLen should be set less than 82526 (current value is 2097152), to avoid possible runtime oom issues.', /Users/jasl/.cargo/git/checkouts/substrate-7e08433d4c370a21/1837f42/frame/contracts/src/lib.rs:396:13

A bit tricky for this one. Max size of 82526 is obviously not acceptable for phat contracts. They hard-coded a limitation in the tests and we can not change it. Let's make a workaround temporarily in order to pass the testing and discuss with parity for a better solution. I've left a message there on the parity's Element group.

No feature changes from 0.16.1 to 0.16.2. So I think we can ignore it.

@jasl jasl marked this pull request as ready for review March 21, 2023 10:20
Copy link
Collaborator

@kvinwang kvinwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasl jasl enabled auto-merge March 22, 2023 10:41
@jasl jasl merged commit 2012308 into master Mar 22, 2023
@jasl jasl deleted the polkadot-v0.9.39 branch March 22, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants