-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pruntime: Sidevm incoming HTTP stream via pRuntime RPC #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvinwang
force-pushed
the
sidevm-stream
branch
from
September 18, 2023 12:56
04df4fa
to
076f088
Compare
kvinwang
force-pushed
the
sidevm-stream
branch
2 times, most recently
from
October 8, 2023 03:32
37ca8bd
to
d4831f0
Compare
kvinwang
force-pushed
the
sidevm-stream
branch
from
October 23, 2023 07:03
19f36f8
to
def2044
Compare
kvinwang
force-pushed
the
sidevm-stream
branch
from
October 25, 2023 10:42
8ba4eed
to
1ff2e4a
Compare
kvinwang
changed the title
Sidevm incoming HTTP stream via pRuntime RPC
pruntime: Sidevm incoming HTTP stream via pRuntime RPC
Nov 26, 2023
h4x3rotab
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the capability for SideVM instances to listen for incoming HTTP requests on a pRPC endpoint.
With this PR, SideVM instances gain the ability to receive incoming HTTP requests with a specific path pattern:
/sidevm/<contract address>/<res_path>
.Cookie/Set-Cookie
are filtered out for security reason as multiple contract would share the same HTTP origin.Features/limitations of the stream:
Asynchronous reading and writing of the body stream is supported. This allows applications to efficiently manage streaming APIs and implement WebSocket within the app space.
HTTP headers
Cookie
andSet-Cookie
are filtered out for security reasons, as multiple contracts share the same origin in the phat contract.