Update and reorganise copy data sets methods (Fix for #1604). #4008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copying class properties is always done in protected copy method.
|
Nice work, looks fine from here. |
RobertZagorski
deleted the
bugfix/#1604-update-and-reorganise--copy-data-sets-methods
branch
regas99
pushed a commit
to regas99/MPAndroidChart
that referenced
this pull request
Apr 1, 2019
…-update-and-reorganise--copy-data-sets-methods Update and reorganise copy data sets methods (Fix for PhilJay#1604).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue has already been created where the problem: [#1604]
PR Description
Copying data sets methods were missing some fields. I refactored the way data sets are copied and added missing fields.