fix Poolable object leak context issue #4502
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would really appreciate this patch. Leakcanary caught the memory leak for me. |
|
Do you have a schedulle on when this will be in a new version? |
|
Merged this at https://github.com/SubhrajyotiSen/MPAndroidChart which will be an updated fork |
|
Hello, Leak Canary also detected this memory leak in our app. Any chance this PR will be merged soon? |
Shekhanzai
approved these changes
Oct 4, 2024
Contributor
This was referenced Jul 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
As we know ObjectPool cache some Poolable Objects, but some Poolable Object reference to View
Object, and View Object reference to Context Object, And ObjectPool is static, so leak Context. For exsmple, ObjectPool.objects ---> AnimatedMoveViewJob.view ---> View.mContext ---> Context
For this issue, I Clear Poolable Object fields when Poolable Object is recycled. Please check patch code
I think lots of memory leak occurs when using MPAndroidChart, so please merge this patch.