update to python3 and pyqt5 #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used 2to3 to update to python3 made small changes for compatibility, mainly encode/decode for byte strings also change from buffer to memoryview Additionally upgraded to pyqt5 as pyqt4 support seems to be deprecated in many new python distributions, just renaming of and relocating of various packages/classes, no real changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Phil, I updated things to make liveplot compatible with python3 and pyqt5...the demo scripts all seem to work at least. description of changes below. One thing I did not change but probably would need updating is the setup.py. One could probably make things compatible to both python2.7 and pyqt4 as well as the newer ones without too much work but not sure if its worth the effort.
Used 2to3 to update to python3
made small changes for compatibility, mainly encode/decode for byte strings
also change from buffer to memoryview
Additionally upgraded to pyqt5 as pyqt4 support seems to be deprecated in many new python distributions, just renaming of and relocating of various packages/classes, no real changes