Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to log out from the front end #619

Closed
reefdog opened this issue Mar 5, 2024 · 2 comments · Fixed by #696
Closed

Add ability to log out from the front end #619

reefdog opened this issue Mar 5, 2024 · 2 comments · Fixed by #696
Assignees
@reefdog

Comments

@reefdog
Copy link
Contributor

reefdog commented Mar 5, 2024

We need to be able to log out from the front end. I'm leaving this intentionally vague because I don't know if this is a route, a form POST, or what, but it'll be triggered by a "Logout" button in the user menu (#618) once that exists.
@reefdog reefdog changed the title Add logout functionality to front end Add ability to logout from the front end Mar 5, 2024
@reefdog reefdog mentioned this issue Mar 5, 2024
Closed
@reefdog
Copy link
Contributor Author

reefdog commented Apr 4, 2024 •
edited
Loading

Here's what that will look like:

User menu with logout 
<DropdownMenuLink
  to={accountManagementUrl}
  icon={<PowerIcon />}
  className="logout"
  key="logout"
>
  Log out
</DropdownMenuLink>

@reefdog reefdog mentioned this issue Apr 4, 2024
Closed
@reefdog reefdog changed the title Add ability to logout from the front end Add ability to log out from the front end Apr 10, 2024
@reefdog reefdog assigned reefdog and unassigned hminsky2002 Apr 18, 2024
@reefdog
Copy link
Contributor Author

reefdog commented Apr 18, 2024

@hminsky2002 Indeed this one ended up being so easy I can handle it myself! Will have a PR for you to review by EOD. 🎉

reefdog added a commit that referenced this issue Apr 19, 2024
@reefdog
Add DropdownMenuButton component
e8af35e 
In addition to links, we may want dropdown items to be buttons. This
commit adds support with the `DropdownMenuButton` component as a
companion to `DropdownMenuLink`. Consequently, it renames the shared
class names to `dropdown-menu-item`.

Issue #619 Add ability to log out from the front end
reefdog added a commit that referenced this issue Apr 19, 2024
@reefdog
Add user menu with logout button
cac5538 
Includes a change that lets dropdown menus get smaller (but not too
small) if their contents aren’t wide. This looks better for emptier
menus like the user menu.

(The user menu will gain more functionality with #618.)

Issue #619 Add ability to log out from the front end
@reefdog reefdog mentioned this issue Apr 19, 2024
Merged
reefdog added a commit that referenced this issue Apr 19, 2024
@reefdog
Add DropdownMenuButton component
8710e0a 
In addition to links, we may want dropdown items to be buttons. This
commit adds support with the `DropdownMenuButton` component as a
companion to `DropdownMenuLink`. Consequently, it renames the shared
class names to `dropdown-menu-item`.

Issue #619 Add ability to log out from the front end
reefdog added a commit that referenced this issue Apr 19, 2024
@reefdog
Add user menu with logout button
a3f0928 
Includes a change that lets dropdown menus get smaller (but not too
small) if their contents aren’t wide. This looks better for emptier
menus like the user menu.

(The user menu will gain more functionality with #618.)

Issue #619 Add ability to log out from the front end
reefdog added a commit that referenced this issue Apr 19, 2024
@reefdog
Add DropdownMenuButton component
3a77c34 
In addition to links, we may want dropdown items to be buttons. This
commit adds support with the `DropdownMenuButton` component as a
companion to `DropdownMenuLink`. Consequently, it renames the shared
class names to `dropdown-menu-item`.

Issue #619 Add ability to log out from the front end
reefdog added a commit that referenced this issue Apr 19, 2024
@reefdog
Add user menu with logout button
c669743 
Includes a change that lets dropdown menus get smaller (but not too
small) if their contents aren’t wide. This looks better for emptier
menus like the user menu.

(The user menu will gain more functionality with #618.)

Issue #619 Add ability to log out from the front end
reefdog added a commit that referenced this issue Apr 20, 2024
@reefdog
Add DropdownMenuButton component
74b2b57 
In addition to links, we may want dropdown items to be buttons. This
commit adds support with the `DropdownMenuButton` component as a
companion to `DropdownMenuLink`. Consequently, it renames the shared
class names to `dropdown-menu-item`.

Issue #619 Add ability to log out from the front end
reefdog added a commit that referenced this issue Apr 20, 2024
@reefdog
Add user menu with logout button
1452c4c 
Includes a change that lets dropdown menus get smaller (but not too
small) if their contents aren’t wide. This looks better for emptier
menus like the user menu.

(The user menu will gain more functionality with #618.)

Issue #619 Add ability to log out from the front end
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reefdog reefdog

Labels
None yet
Projects
Phase 2
Status: Done & Cleared
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add user logout PhilanthropyDataCommons/front-end
2 participants
@reefdog @hminsky2002