Improve display of navbar dropdowns #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reduces our use of decorative small type, which can be inaccessible to low-sight users. Except for very specific contexts (such as inline code, which renders in monotype text, which appears larger than surrounding sans-serif type anyway), we limit our “small text” to only 5% smaller than root, e.g., `0.95rem`. Some elements will now appear a little larger (navbar items, decorative headers, badges, sidebar metadata). Some will look the same but now use a global CSS variable. No issue, but a prerequisite task for work on #667.
Prior to this commit, we had a bit of an ad hoc / HTML-native way of adding descriptions to dropdown menu items, customized just for our two current navbar dropdowns. This felt unidiomatic both for React and for our Dropdown component ergonomics. Now, we have a `DropdownMenuLinkDescription` component that you can optionally add to a `DropdownMenuLink`, alongside the existing text, which renders some smaller explanatory text below the title. Along the way, we also: - Change the styling of these navbar items with descriptions so that they match items without descriptions. (h/t @slifty) - Make sure menu link icons stay aligned with the “title” of the link, not centered by the description — and don’t let them shrink - Update stories to match (and with more representative examples) Issue #667 Change formatting of navbar dropdowns
✅ Deploy Preview for philanthropy-data-commons-viewer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
In browsers/OSes that support keyboard-tabbing through link controls, our dropdown menus can be tabbed-through. Prior to this commit, however, the focus outlines were clipped. No longer! Now they are visible, and even curved at top and bottom to match the menu itself.
hminsky2002
reviewed
Apr 10, 2024
| @@ -67,8 +67,15 @@ | |||
| border-bottom: 1px solid var(--color--gray--light); | |||
| } | |||
|
|
|||
| .dropdown-menu > *:first-child { | |||
| border-top-left-radius: var(--dropdown--menu--border-radius); | |||
There was a problem hiding this comment.
I did not know that this was a thing you could set with css, very cool!
There was a problem hiding this comment.
Do you mean CSS variables, or setting the border radius?
hminsky2002
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the look of our navbar dropdowns in preparation for the user menu dropdown (#618).
Before:
After:
If you think that's a stylistic regression…
Maybe some of you will think "Ah, but, that's less attractive!" And you're not wrong, but, the new format looks better when interleaved with more traditional dropdown items (which we don't want to always force into the "small uppercase" format):
navbar.mov
Along for the ride come some text accessibility improvements and an improvement to the
:focusoutline when keyboard-navigating the menu.Testing:
You can test this via the deploy preview, since the affected menus are available while logged-out. You can also hit the Storybook deployment to see the updated Dropdown stories. Just make sure dropdowns are legible and not a regression from earlier forms.
Resolves #667