Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix module paths - Fixes #115 #116

Merged
merged 1 commit into from
Apr 24, 2021
Merged

Conversation

Jleagle
Copy link
Contributor

@Jleagle Jleagle commented Apr 19, 2021

I could remove all the dot import aliases too if you like as they are not recommended.

@gudvinr, could you check this over pease.

@gudvinr
Copy link

gudvinr commented Apr 19, 2021

I don't think you're supposed to edit steamid/steamid.go since it doesn't have imports from github.com/Philipp15b/go-steam.
Since I'm not an author I can't say much but it looks pretty straightforward.

And I personally agree that dot imports must go. But it's a good idea to fill a different PR for that

@Philipp15b
Copy link
Owner

Thanks a bunch! I assume steamid.go had wrong line endings or why was the whole file changed?

I'll also happily accept another PR to remove dot imports. That might be a bit more difficult though as the generator must be adapted as well.

@Jleagle
Copy link
Contributor Author

Jleagle commented Apr 20, 2021

Yep, assumed it was line endings, let me know if you want me to revert the file.

@gudvinr
Copy link

gudvinr commented Apr 20, 2021

Thanks a bunch! I assume steamid.go had wrong line endings or why was the whole file changed?

You can use .gitattributes or core.eol option for git and it'lll convert automatically.

@Philipp15b Philipp15b merged commit 19f4df7 into Philipp15b:master Apr 24, 2021
@Philipp15b
Copy link
Owner

Thanks @Jleagle!

@Jleagle Jleagle mentioned this pull request Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants