feat(SaleHeaderBanner): L3-4648 add countdown to sale header banner f… #435
Conversation
…or timed auctions
aahill50
requested review from
davidicus,
justinelliottcobb,
adietrich3074,
scottdickerson,
constantinehuzenko and
sgrund14
as code owners
✅ Deploy Preview for phillips-seldon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
aahill50
force-pushed
the
L3-4648-update-sale-header-banner-to-support-timed-auctions
branch
from
557a96d to
f59696a
Compare
| /> | ||
| <PageMargin className={`${baseClassName}__stack-wrapper`} {...commonProps} {...props} ref={ref}> | ||
| {showCountdown && ( | ||
| <Countdown endDateTime={new Date(auctionEndTime)} className={`${baseClassName}__countdown`} /> |
There was a problem hiding this comment.
I believe they moved the countdown timer above the banner image on mobile. Not sure why Figma is showing both above and below. We can utilize the media query util we use in other components like footer.
There was a problem hiding this comment.
Weird, I think it was only on the bottom when I first started working on it, but now I see it in both places in figma... But I just pushed up a commit that moves it to the top and gets rid of the bottom border for the mobile layout
| @@ -86,7 +97,11 @@ const SaleHeaderBanner = forwardRef<HTMLDivElement, SaleHeaderBannerProps>( | |||
| /> | |||
| <PageMargin className={`${baseClassName}__stack-wrapper`} {...commonProps} {...props} ref={ref}> | |||
| <div className={`${baseClassName}__stack`}> | |||
| {isOpenForBidding && children} | |||
| {isOpenForBidding && auctionEndTime && ( | |||
There was a problem hiding this comment.
apparently we prefer doing this
{isOpenForBidding && auctionEndTime ? (<Component />) : null}
but I think it's ok if there are no numbers involved
sometimes you get weird stuff where if auctionEndTIme was 0, it would just render a 0 on the page
but that shouldn't happen here
There was a problem hiding this comment.
That's usually how I prefer to do it, but I was just following the convention that was already in the file... but since you mentioned it, I just pushed up a refactor commit to change all the conditional rendering in this file to ternarys
aahill50
deleted the
L3-4648-update-sale-header-banner-to-support-timed-auctions
branch
# [1.99.0](v1.98.1...v1.99.0) (2024-12-03) ### Features * **SaleHeaderBanner:** L3-4648 add countdown to sale header banner f… ([#435](#435)) ([716701e](716701e))
|
🎉 This issue has been resolved in version 1.99.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
…or timed auctions
Jira ticket
L3-4648
Screenshots
Summary
Adds the countdown timer to the top of Time Auction Sale pages
Change List (describe the changes made to the files)
Acceptance Test (how to verify the PR)
Regression Test
Evidence of testing
Things to look for during review
feat(scope): ...if aminorrelease should be triggered.phillipsclass prefix are using the prefix variabledata-testidattribute.New Components
index.tsfilecomponentStyles.scssfile.