Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

Add BaseTransformSeeded and warnings to other transforms #100

Merged
merged 3 commits into from
May 18, 2020

Conversation

mibaumgartner
Copy link
Member

Short Description

Please give a short summary of the main points of this PR

PR Checklist

PR Implementer

This is a small checklist for the implementation details of this PR.
If you submit a PR, please look at these points (don't worry about the RisingTeam
and Reviewer workflows, the only purpose of those is to have a compact view of
the steps)

If there are any questions regarding code style or other conventions check out our
summary.

  • Implementation
  • Docstrings & Typing
  • Check __all__ sections and __init__
  • Unittests (look at the line coverage of your tests, the goal is 100%!)
  • Update notebooks & documentation if necessary
  • Pass all tests
  • Add the checksum of the last implementation commit to the Changelog

RisingTeam

RisingTeam workflow
  • Add pull request to project (optionally delete corresponding project note)
  • Assign correct label (if you don't have permission to do this, someone will do it for you.
    Please make sure to communicate the current status of the pr.)
  • Does this PR close an Issue? (add closes #IssueNumber at the bottom if
    not already in description)

Reviewer

Reviewer workflow
  • Do all tests pass? (Unittests, NotebookTests, Documentation)
  • Does the implementation follow rising design conventions?
  • Are the tests useful? (!!!) Are additional tests needed?
    Can you think of critical points which should be covered in an additional test?
  • Optional: Check coverage locally / Check tests locally if GPU is necessary to execute

@mibaumgartner mibaumgartner added Bug Something isn't working ReadyForReview Ready for review labels May 18, 2020
@mibaumgartner mibaumgartner linked an issue May 18, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 18, 2020

Codecov Report

Merging #100 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
+ Coverage   97.83%   97.85%   +0.02%     
==========================================
  Files          36       36              
  Lines        1384     1398      +14     
==========================================
+ Hits         1354     1368      +14     
  Misses         30       30              
Flag Coverage Δ
#unittests 97.85% <100.00%> (+0.02%) ⬆️
Impacted Files Coverage Δ
rising/transforms/intensity.py 100.00% <ø> (ø)
rising/transforms/abstract.py 98.05% <100.00%> (+0.23%) ⬆️
rising/transforms/crop.py 100.00% <100.00%> (ø)
rising/transforms/functional/crop.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71cb42f...c226a23. Read the comment docs.

@mibaumgartner mibaumgartner merged commit fd3b79f into master May 18, 2020
@justusschock justusschock deleted the random_crop_seed branch July 26, 2021 15:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something isn't working ReadyForReview Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] RandomCrop cropping several keys differently
2 participants