Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

add per sample option for affine transforms #83

Merged
merged 3 commits into from
May 17, 2020

Conversation

mibaumgartner
Copy link
Member

Short Description

  • per sample option for affine transform

PR Checklist

PR Implementer

This is a small checklist for the implementation details of this PR.
If you submit a PR, please look at these points (don't worry about the RisingTeam
and Reviewer workflows, the only purpose of those is to have a compact view of
the steps)

If there are any questions regarding code style or other conventions check out our
summary.

  • Implementation
  • Docstrings & Typing
  • Check __all__ sections and __init__
  • Unittests (look at the line coverage of your tests, the goal is 100%!)
  • Update notebooks & documentation if necessary
  • Pass all tests
  • Add the checksum of the last implementation commit to the Changelog

RisingTeam

RisingTeam workflow
  • Add pull request to project (optionally delete corresponding project note)
  • Assign correct label (if you don't have permission to do this, someone will do it for you.
    Please make sure to communicate the current status of the pr.)
  • Does this PR close an Issue? (add closes #IssueNumber at the bottom if
    not already in description)

Reviewer

Reviewer workflow
  • Do all tests pass? (Unittests, NotebookTests, Documentation)
  • Does the implementation follow rising design conventions?
  • Are the tests useful? (!!!) Are additional tests needed?
    Can you think of critical points which should be covered in an additional test?
  • Optional: Check coverage locally / Check tests locally if GPU is necessary to execute

@mibaumgartner mibaumgartner added the ReadyForReview Ready for review label May 16, 2020
@codecov
Copy link

codecov bot commented May 16, 2020

Codecov Report

Merging #83 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #83   +/-   ##
=======================================
  Coverage   97.83%   97.83%           
=======================================
  Files          36       36           
  Lines        1383     1384    +1     
=======================================
+ Hits         1353     1354    +1     
  Misses         30       30           
Flag Coverage Δ
#unittests 97.83% <100.00%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
rising/transforms/affine.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df527fa...60fa1cf. Read the comment docs.

rising/transforms/affine.py Show resolved Hide resolved
@mibaumgartner mibaumgartner merged commit c4f797d into master May 17, 2020
@justusschock justusschock deleted the per_sample_transforms branch May 17, 2020 17:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ReadyForReview Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants