Merge remote-tracking branch 'upstream/master' #34
ShootingKing-AMAnnotations
8 warnings
|
wiki
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, cmbrose/github-docs-to-wiki@v0.24. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
the borrowed expression implements the required traits:
alvr/launcher/src/main.rs#L761
warning: the borrowed expression implements the required traits
--> alvr/launcher/src/main.rs:761:24
|
761 | fs::create_dir_all(&installation_dir)?;
| ^^^^^^^^^^^^^^^^^ help: change this to: `installation_dir`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
variable does not need to be mutable:
alvr/launcher/src/main.rs#L759
warning: variable does not need to be mutable
--> alvr/launcher/src/main.rs:759:9
|
759 | let mut installation_dir = data_dir().extended(VERSIONS_SUBDIR).extended(&release.tag);
| ----^^^^^^^^^^^^^^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
|
|
unused variable: `buffer`:
alvr/launcher/src/main.rs#L757
warning: unused variable: `buffer`
--> alvr/launcher/src/main.rs:757:9
|
757 | let buffer = download(tx, "Downloading Streamer", &url, client).await?;
| ^^^^^^ help: if this is intentional, prefix it with an underscore: `_buffer`
|
= note: `#[warn(unused_variables)]` on by default
|
|
unreachable expression:
alvr/launcher/src/main.rs#L780
warning: unreachable expression
--> alvr/launcher/src/main.rs:780:5
|
763 | / match installation_type {
764 | | #[cfg(target_os = "linux")]
765 | | InstallationType::AppImage => {
766 | | installation_dir.push("ALVR-x86_64.AppImage");
... |
778 | | }
779 | | }
| |_____- any code following this `match` expression is unreachable, as all arms diverge
780 | Ok(())
| ^^^^^^ unreachable expression
|
= note: `#[warn(unreachable_code)]` on by default
|
|
unused import: `Permissions`:
alvr/launcher/src/main.rs#L6
warning: unused import: `Permissions`
--> alvr/launcher/src/main.rs:6:22
|
6 | fs::{self, File, Permissions},
| ^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
variable does not need to be mutable:
alvr\launcher\src\main.rs#L759
warning: variable does not need to be mutable
--> alvr\launcher\src\main.rs:759:9
|
759 | let mut installation_dir = data_dir().extended(VERSIONS_SUBDIR).extended(&release.tag);
| ----^^^^^^^^^^^^^^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
|
|
unused import: `Permissions`:
alvr\launcher\src\main.rs#L6
warning: unused import: `Permissions`
--> alvr\launcher\src\main.rs:6:22
|
6 | fs::{self, File, Permissions},
| ^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|