[Bug] SteamVR Headset Detection Issue Fix #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: SteamVR was not able detect PhoneVR Android device as headset. Problem was PhoneVR Android app was not able to send Android Acceleration Sensor Data through [PVRStartSensorData()](https://github.com/ShootingKing-AM/PhoneVR/blob/master/code/mobile/mobile-common/PVRSockets.cpp#L121) which was getting hold by [ref.wait()](https://github.com/ShootingKing-AM/PhoneVR/blob/master/code/mobile/mobile-common/PVRSockets.cpp#L140) This issue was not obseved in Debug build of app, only occuring on Release build. [Variables](https://github.com/ShootingKing-AM/PhoneVR/blob/master/code/common/src/Utils/ThreadUtils.h#L131-L134) were not initialized in Release build, resulting in infinite wait.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: SteamVR was not able detect PhoneVR Android device as headset.
Problem was PhoneVR Android app was not able to send Android Acceleration Sensor Data through PVRStartSensorData() which was getting hold by ref.wait()
This issue was not obseved in Debug build of app, only occuring on Release build. Variables were not initialized in Release build, resulting in infinite wait.
Related issues: #24, #26