Skip to content

Commit

Permalink
Fix missing vars and catch bad shim (#1541)
Browse files Browse the repository at this point in the history
I made a mistake when cherry-picking things into #1534. Fixing it also
prompted me to regenerate message things without thinking even though it
wasn't needed here but it helped me catch an issue with a bad shim. I
must not have saved it properly on my computer and missed it before
review.
  • Loading branch information
LucienMorey authored Nov 9, 2024
1 parent 14fcc5d commit d188c37
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions photon-lib/py/photonlibpy/targeting/photonTrackedTarget.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ class PhotonTrackedTarget:
minAreaRectCorners: list[TargetCorner] = field(default_factory=list[TargetCorner])
detectedCorners: list[TargetCorner] = field(default_factory=list[TargetCorner])
poseAmbiguity: float = 0.0
objDetectId: int = -1
objDetectConf: float = 0.0

def getYaw(self) -> float:
return self.yaw
Expand Down
2 changes: 1 addition & 1 deletion photon-serde/message_data_types.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ int32:
java_type: int
cpp_type: int32_t
java_decode_method: decodeInt
java_encode_shim: encodeBoolean
java_encode_shim: encodeInt
int64:
len: 8
java_type: long
Expand Down

0 comments on commit d188c37

Please sign in to comment.