-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support selecting Object Detection models #1359
Conversation
7a68919
to
f3dbec3
Compare
photon-core/src/main/java/org/photonvision/common/configuration/NeuralNetworkModelManager.java
Outdated
Show resolved
Hide resolved
Sadly I think I need to click the approve workflow button every time you push until you make at least one contribution |
Skill issue on my part. Sorry! |
What do we think about the design for defining model labels?
My thought process is that someday when we are able to support uploading models in different formats we might see something like:
|
I think that potential conflict (with keeping track of label names/number of classes across different model types with the same name) makes me a little scared. |
What I'm going for is all those files encode the same "model" - just in different file formats. The difference between The metadata format I'm going for is The alternative is you have multiple copies of the same model (keyed by '"name"`) and you risk screwing up writing the labels file. |
I feel pretty good about the implementation so far. I have a question, how can I go about getting the list of available models from core to the client? I need to give the UI a |
photon-client/src/components/dashboard/tabs/ObjectDetectionTab.vue
Outdated
Show resolved
Hide resolved
Ready for review - if someone is able to test this code running on hardware that would be great. |
photon-core/src/main/java/org/photonvision/common/configuration/NeuralNetworkModelManager.java
Show resolved
Hide resolved
photon-core/src/main/java/org/photonvision/common/configuration/NeuralNetworkModelManager.java
Outdated
Show resolved
Hide resolved
photon-core/src/main/java/org/photonvision/common/configuration/NeuralNetworkModelManager.java
Outdated
Show resolved
Hide resolved
photon-core/src/main/java/org/photonvision/jni/RknnObjectDetector.java
Outdated
Show resolved
Hide resolved
photon-client/src/components/dashboard/tabs/ObjectDetectionTab.vue
Outdated
Show resolved
Hide resolved
At the moment this is hung up on extracting models from the JAR. There is some kind of platform dependency - I'll work through it and move on to testing the actual implementation. |
6554a42
to
52b9ec8
Compare
52b9ec8
to
4feb3a0
Compare
I'm preparing a more reviewable patch set! |
…d to model changes
47a54a9
to
865f829
Compare
865f829
to
53c7647
Compare
To have a second model to test with I just copied the existing one but slightly changed the name.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it idk man it works on my computer
This PR is for part 1 of #1354. It focuses on adding a model selection interface for models that exist in
photonvision_config/models/
. Upon completion we can ship more than 1 model and users could upload their own throughssh
without deleting the shipped model. This PR also adds the abstractions need to support more DNN backends (say OpenCV, or RPI AI Kit)Up next is adding a CRUD interface for managing models through the UI.