Client log view improvements #1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The GOAT returns |
|
This reminds me - we should open a ticket to grab log messages from before the UI connects. We do this in a hacky way right now, but only for the first client. |
|
This needs to be done in the composition Vue API for the transition to Vue3, I already have Spacing, coloring, reactivity, and styling on the vue3 branch. Will PR soon, we should merge this either directly in that PR or after we merge that one. |
| {{ getLogLevelFromIndex(level) }} | ||
| </v-col> | ||
| <v-col cols="6" md="4"> | ||
| <v-switch v-model="selectedLogLevels[level]" dark color="#ffd843" /> |
There was a problem hiding this comment.
Whats the reason to replace the button toggle with switches?
|
closes #1384 |
mcm001
approved these changes
Aug 31, 2024
@DevonRD not using pnpm anymore until we can bump to Vue3 because of legacy peer dependency resolution issues
|
These changes will likely have to be looked at again during the Vue3 changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following issues with client log view:
Adds the following features to log view:
*A couple files have inconsequential changes from linting/formatting