Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FMS info to snapshot names #1460

Merged
merged 1 commit into from
Oct 13, 2024
Merged

Add FMS info to snapshot names #1460

merged 1 commit into from
Oct 13, 2024

Conversation

mcm001
Copy link
Contributor

@mcm001 mcm001 commented Oct 13, 2024

Supersedes #464

@OfirSiboni @mcm001
added FMS match info in snapshot name
c5673be 
added FMS match info in snapshot name

reverted unwanted changes

added data validation

Address review comments

Co-authored-by: Matt Morley <matthew.morley.ca@gmail.com>
@mcm001 mcm001 requested a review from a team as a code owner October 13, 2024 15:58
@mcm001 mcm001 mentioned this pull request Oct 13, 2024
Closed
mcm001
mcm001 commented Oct 13, 2024
View reviewed changes
Copy link
Contributor Author

@mcm001 mcm001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

obama.png

@mcm001 mcm001 merged commit 353a8ea into PhotonVision:master Oct 13, 2024
31 checks passed
@mcm001 mcm001 deleted the OfirSiboni/master branch October 13, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcm001 @OfirSiboni