Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nonsensical includes #1505

Conversation

spacey-sooty
Copy link
Member

@spacey-sooty spacey-sooty commented Oct 29, 2024

Having these in the root settings.gradle means they are subprojects but
the settings.gradles in these folders shows they aren't

Having these in the root settings.gradle means they are subprojects but
the settings.gradles in these folders shows they aren't

Signed-off-by: Jade Turner <spacey-sooty@proton.me>
@spacey-sooty spacey-sooty requested a review from a team as a code owner October 29, 2024 04:38
@spacey-sooty spacey-sooty changed the title Remove explicit NativeUtils specification (#1495) Remove nonsensical includes Oct 29, 2024
@mcm001
Copy link
Contributor

mcm001 commented Oct 29, 2024

Photon-core and server are intended to be subprojects.

@spacey-sooty
Copy link
Member Author

Photon-core and server are intended to be subprojects.

That makes sense I'll make a new PR fixing the silly settings.gradle's

@spacey-sooty spacey-sooty deleted the remove-nonsensical-includes branch October 29, 2024 04:58
spacey-sooty added a commit to spacey-sooty/photonvision that referenced this pull request Oct 29, 2024
See PhotonVision#1505 for reasoning

Signed-off-by: Jade Turner <spacey-sooty@proton.me>
spacey-sooty added a commit to spacey-sooty/photonvision that referenced this pull request Oct 29, 2024
See PhotonVision#1505 for reasoning

Signed-off-by: Jade Turner <spacey-sooty@proton.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants