Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to specify that WPILib JDK is required on Windows #1522

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

willtoth
Copy link
Contributor

@willtoth willtoth commented Nov 5, 2024

When building on Windows, the WPILib shipped JDK is required due to an ABI breakage on std::mutex. More details on Discord: https://discord.com/channels/176186766946992128/368993897495527424/1256860668406005821

@willtoth willtoth requested a review from a team as a code owner November 5, 2024 03:23
@mcm001
Copy link
Contributor

mcm001 commented Nov 5, 2024

This technically so applies to actually running PhotonVision but send it

When building on Windows, the WPILib shipped JDK is required due
to an ABI breakage on std::mutex. More details on Discord:
https://discord.com/channels/176186766946992128/368993897495527424/1256860668406005821
@mcm001 mcm001 merged commit a0b22cd into PhotonVision:master Nov 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants