Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing vars and catch bad shim #1541

Merged
merged 2 commits into from
Nov 9, 2024
Merged

Fix missing vars and catch bad shim #1541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79c7418
fix bad encoding shim that was reverted at some point
LucienMorey Nov 9, 2024
f916578
add missing types to photonTrackedTarget
LucienMorey Nov 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions photon-lib/py/photonlibpy/targeting/photonTrackedTarget.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ class PhotonTrackedTarget:
minAreaRectCorners: list[TargetCorner] = field(default_factory=list[TargetCorner])
detectedCorners: list[TargetCorner] = field(default_factory=list[TargetCorner])
poseAmbiguity: float = 0.0
objDetectId: int = -1
objDetectConf: float = 0.0

def getYaw(self) -> float:
return self.yaw
Expand Down
2 changes: 1 addition & 1 deletion photon-serde/message_data_types.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ int32:
java_type: int
cpp_type: int32_t
java_decode_method: decodeInt
java_encode_shim: encodeBoolean
java_encode_shim: encodeInt
int64:
len: 8
java_type: long
Expand Down
Loading