simplify function args to use default rather than being None #1595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
mcm001
requested changes
Nov 20, 2024
| self, result: PhotonPipelineResult, receiveTimestamp: float | None | ||
| self, | ||
| result: PhotonPipelineResult, | ||
| receiveTimestamp: float = wpilib.Timer.getFPGATimestamp() * 1e6, |
There was a problem hiding this comment.
When does this default get evaluated?
There was a problem hiding this comment.
Good call. I dont think there is a solution to this without drastically changing the typings
There was a problem hiding this comment.
Could you check if none and then default to getFpgaTimestamp?
There was a problem hiding this comment.
Thats basically what it is right now without screwing with the type signature of the function to make it do funny things. The intent of this was to remove optional typing from the signature and if that cant be sorted I don't think this is worth worrying about
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty benign change, but I noticed it when I was doing docs for everything, and it's been a brain worm since...