Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootup sprint #18

Merged
merged 61 commits into from
Jul 7, 2020
Merged

Bootup sprint #18

merged 61 commits into from
Jul 7, 2020

Conversation

mcm001
Copy link
Contributor

@mcm001 mcm001 commented Jul 7, 2020

Kinda touches everything.

  • UI dataflow rework
  • Fill in VMM and SocketHandler

Still doesn't support HTTP requests

@mcm001 mcm001 requested a review from Bankst July 7, 2020 05:58
@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #18 into master will decrease coverage by 9.39%.
The diff coverage is 28.53%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #18      +/-   ##
============================================
- Coverage     59.15%   49.76%   -9.40%     
- Complexity      372      424      +52     
============================================
  Files           114      140      +26     
  Lines          2850     3820     +970     
  Branches        265      350      +85     
============================================
+ Hits           1686     1901     +215     
- Misses         1029     1810     +781     
+ Partials        135      109      -26     
Impacted Files Coverage Δ Complexity Δ
...on-server/src/main/java/org/photonvision/Main.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...sion/common/configuration/PhotonConfiguration.java 44.44% <0.00%> (-41.27%) 6.00 <0.00> (ø)
...ision/common/dataflow/events/HTTPRequestEvent.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...common/dataflow/events/IncomingWebSocketEvent.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...n/dataflow/networktables/NetworkTablesManager.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ision/common/dataflow/structures/BytePackable.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...mmon/dataflow/structures/SimplePipelineResult.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ommon/dataflow/structures/SimpleTrackedTarget.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...tatransfer/networktables/NetworkTablesManager.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...g/photonvision/common/util/SerializationUtils.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01712a7...1c94b8f. Read the comment docs.

@Bankst Bankst merged commit 4cd2262 into PhotonVision:master Jul 7, 2020
@Bankst Bankst deleted the bootup-sprint branch July 11, 2020 18:19
Comment on lines -119 to +111
return camera.getVideoMode();
return camera.isConnected() ? camera.getVideoMode() : null;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whyd I add this?

@mcm001 mcm001 mentioned this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants