Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Presence of data-template, without binding a list, should leave the parent "empty" #363

Closed
g105b opened this issue Jul 15, 2022 · 0 comments · Fixed by #394
Closed

Presence of data-template, without binding a list, should leave the parent "empty" #363

g105b opened this issue Jul 15, 2022 · 0 comments · Fixed by #394
Labels
enhancement

Comments

@g105b
Copy link
Member

g105b commented Jul 15, 2022

When bindList is used, if the list is empty, the template parent will have all whitespace stripped so that CSS sees it as :empty.

This should be the case for simply having a data-template attribute on an element. Assuming there are no other children in the template parent, when the template item is removed from the DOM, the parent should have whitespace stripped so that if nothing is bound, css still sees the element as :empty.
g105b added a commit that referenced this issue Jan 17, 2023
@g105b
feature: trim whitespace when there are only template children
3dbda21 
closes #363
@g105b g105b mentioned this issue Jan 17, 2023
Merged
g105b added a commit that referenced this issue Jan 17, 2023
@g105b
Trim whitespace where there are only template children in an element (#…
bfdbb05 
…394)

* build: upgrade dom requirement and loosen version range

* docs: update examples

* feature: trim whitespace when there are only template children
closes #363
g105b added a commit that referenced this issue Jan 18, 2023
@g105b
Binding a list of options, with already existing select options (#395)
fe3f2e3 
* build: upgrade dom requirement and loosen version range

* docs: update examples

* feature: trim whitespace when there are only template children
closes #363

* feature: ensure existing options persist in the correct order
closes #369
g105b added a commit that referenced this issue Jan 26, 2023
@g105b
Modifier tests - more tests to enforce documented functionality (#396)
ec8babf 
* build: upgrade dom requirement and loosen version range

* docs: update examples

* feature: trim whitespace when there are only template children
closes #363

* test: add unit tests specifically for modifier characters

* feature: make and test table binding consistent to documented functionality
g105b added a commit that referenced this issue Jan 30, 2023
@g105b
Improvements to TableBinding (#397)
b92a98b 
* build: upgrade dom requirement and loosen version range

* docs: update examples

* feature: trim whitespace when there are only template children
closes #363

* test: improve alternative table data syntax handling

* test: add failing test for issue #247

* docs: correct output example

* wip: working on normalisation

* wip: massively simplify table data normalisation

* feature: all table binding types are fully tested
closes #247

* maintenance: improve static analysis
g105b added a commit that referenced this issue Jan 30, 2023
@g105b
Simplified casting of bind value (#399)
dd5d399 
* build: upgrade dom requirement and loosen version range

* docs: update examples

* feature: trim whitespace when there are only template children
closes #363

* feature: simplify casting in value binding
closes #398
g105b added a commit that referenced this issue Jan 30, 2023
@g105b
Handle [vars] section of comment ini (#401)
98beac1 
* build: upgrade dom requirement and loosen version range

* docs: update examples

* feature: trim whitespace when there are only template children
closes #363

* feature: handle vars section in partial comment ini
closes #400

* tweak: nullable call

* tweak: stan improvement
g105b added a commit that referenced this issue Jan 31, 2023
@g105b
Tidy up after quality analysis (#403)
7ae5310 
* build: upgrade dom requirement and loosen version range

* docs: update examples

* feature: trim whitespace when there are only template children
closes #363

* maintenance: phpstorm analysis improvements
g105b added a commit that referenced this issue Feb 15, 2023
@g105b
PHPUnit 10 (#408)
7383f61 
* build: upgrade dom requirement and loosen version range

* docs: update examples

* build: update dependencies

* feature: trim whitespace when there are only template children
closes #363

* maintenance: phpstorm analysis improvements

* build: upgrade to phpunit 10

* ci: upgrade phpunit

* ci: upgrade workflow

* ci: increase memory limit

* ci: check variable is being set correctly

* tweak: remove error suppression

* ci: move to v3 phpstan
g105b added a commit that referenced this issue Feb 27, 2023
@g105b
Improvements to working with lists of data (data-bind:list and nested…
e687d24 
… object improvements) (#415)

* build: upgrade dom requirement and loosen version range

* docs: update examples

* feature: trim whitespace when there are only template children
closes #363

* maintenance: phpstorm analysis improvements

* test: refactor test helper class

* wip: add test data for big integration

* test: add failing test to cover nested objects
for #356

* test: add extra cases for nested object test

* feature: allow nesting of object properties
closes #356

* maintenance: static analysis improvement

* test: nested objects with bindgetter functions

* test: isolate issue #367

* test: use `data-template-parent` attribute internally instead of id
closes #367

* test: isolate functionality for #368

* wip: implementation for #368 not yet completed

* feature: data-bind:list
closes #368

* tidy: static analysis improvements

* tidy: types of reflection method improved

* tidy: remove unused import

* tidy: nullable reflection type

* tidy: remove unused elements

* docs: add nested music example
g105b added a commit that referenced this issue Mar 1, 2023
@g105b
data-list replaces data-template (#417)
ffda274 
* build: upgrade dom requirement and loosen version range

* docs: update examples

* feature: trim whitespace when there are only template children
closes #363

* maintenance: phpstorm analysis improvements

* test: refactor test helper class

* wip: add test data for big integration

* test: add failing test to cover nested objects
for #356

* test: add extra cases for nested object test

* feature: allow nesting of object properties
closes #356

* maintenance: static analysis improvement

* test: nested objects with bindgetter functions

* test: isolate issue #367

* test: use `data-template-parent` attribute internally instead of id
closes #367

* test: isolate functionality for #368

* wip: implementation for #368 not yet completed

* feature: data-bind:list
closes #368

* tidy: static analysis improvements

* tidy: types of reflection method improved

* tidy: remove unused import

* tidy: nullable reflection type

* tidy: remove unused elements

* docs: add nested music example

* refactor: data-list
for #416

* refactor: data-list
for #416

* refactor: data-list
for #416

* refactor: data-list
for #416
g105b added a commit that referenced this issue Jul 19, 2023
@g105b
data-element (#439)
ad208ed 
* build: upgrade dom requirement and loosen version range

* docs: update examples

* feature: trim whitespace when there are only template children
closes #363

* maintenance: phpstorm analysis improvements

* feature: remove unbound elements that are marked accordingly
closes #438

* test: ensure element does not get removed after bound
for #438

* feature: use `data-element` attribute for #438
g105b added a commit that referenced this issue Jul 19, 2023
@g105b
Remove data-element attribute (#440)
6829c86 
* build: upgrade dom requirement and loosen version range

* docs: update examples

* feature: trim whitespace when there are only template children
closes #363

* maintenance: phpstorm analysis improvements

* feature: remove unbound elements that are marked accordingly
closes #438

* test: ensure element does not get removed after bound
for #438

* feature: use `data-element` attribute for #438

* tweak: remove data-element attribute
g105b added a commit that referenced this issue Jul 20, 2023
@g105b
Fix remove attribute (#441)
70581eb 
* build: upgrade dom requirement and loosen version range

* docs: update examples

* feature: trim whitespace when there are only template children
closes #363

* maintenance: phpstorm analysis improvements

* tweak: remove data-element attribute

* tweak: remove attribute data-element

* tweak: remove elements as last step
g105b added a commit that referenced this issue Aug 9, 2023
@g105b
442 reflection named type (#445)
af9f693 
* build: upgrade dom requirement and loosen version range

* docs: update examples

* feature: trim whitespace when there are only template children
closes #363

* maintenance: phpstorm analysis improvements

* tweak: remove data-element attribute

* fix: type check for ReflectionNamedType
closes #442
g105b added a commit that referenced this issue Oct 19, 2023
@g105b
Bindable object with nested array (#471)
12bf0c6 
* build: upgrade dom requirement and loosen version range

* docs: update examples

* feature: trim whitespace when there are only template children
closes #363

* maintenance: phpstorm analysis improvements

* tweak: remove data-element attribute

* test: isolate bug #443

* fix: nested lists are optionally bound
closes #443

* test: add test for checking there is a list element when binding a list

* test: remove unused function
g105b added a commit that referenced this issue Nov 10, 2023
@g105b
Component binder (#472)
3fd24a9 
* build: upgrade dom requirement and loosen version range

* docs: update examples

* feature: trim whitespace when there are only template children
closes #363

* maintenance: phpstorm analysis improvements

* tweak: remove data-element attribute

* feature: implement ComponentBinder and abstract Binder class
for #470

* fix: bindable cache allows nested nullable objects
closes #474

* refactor: all domtemplate classes set their dependencies outside of the constructor
for #470

* tweak: stricter reflection type checking

* wip: better exception on missing list element

* tweak: handle nullable iterables
closes #473

* tweak: handle binding of outer list item

* tidy: improve types and coverage

* ci: php 8.2

* ci: phpstan level 6
g105b added a commit that referenced this issue Nov 10, 2023
@g105b
Merged iterator aggregate (#479)
913b654 
* build: upgrade dom requirement and loosen version range

* docs: update examples

* feature: trim whitespace when there are only template children
closes #363

* maintenance: phpstorm analysis improvements

* tweak: remove data-element attribute

* test: merge tests from #468
closes #467
g105b added a commit that referenced this issue Dec 31, 2023
@g105b
test: Multiple attribute binding (#480)
2762126 
* build: upgrade dom requirement and loosen version range

* docs: update examples

* feature: trim whitespace when there are only template children
closes #363

* maintenance: phpstorm analysis improvements

* tweak: remove data-element attribute

* test: isolate bug #478

* fix: remove attributes after binding
fixes #478
g105b added a commit that referenced this issue Jan 25, 2024
@g105b
481 remove element (#483)
143aa97 
* build: upgrade dom requirement and loosen version range

* docs: update examples

* feature: trim whitespace when there are only template children
closes #363

* maintenance: phpstorm analysis improvements

* tweak: remove data-element attribute

* feature: remove element from bind key modifier
closes #481

* test: more tests

* tweak: keep up to date with docs

* tweak: simplify iterable objects

* test: add test to missing coverage line
g105b added a commit that referenced this issue Feb 4, 2024
@g105b
Deps (#484)
ebe9545 
* build: upgrade dom requirement and loosen version range

* docs: update examples

* feature: trim whitespace when there are only template children
closes #363

* maintenance: phpstorm analysis improvements

* tweak: remove data-element attribute

* build: bump dependencies for 3.4 release
g105b added a commit that referenced this issue Feb 29, 2024
@g105b
Automatically binding nested array iterators (#487)
743c005 
* build: upgrade dom requirement and loosen version range

* docs: update examples

* feature: trim whitespace when there are only template children
closes #363

* maintenance: phpstorm analysis improvements

* tweak: remove data-element attribute

* fix: recursive call to bindList if value is itself a list
for #486
g105b added a commit that referenced this issue Feb 29, 2024
@g105b
489 bindable cache method OR property name (#490)
716acb1 
* build: upgrade dom requirement and loosen version range

* docs: update examples

* feature: trim whitespace when there are only template children
closes #363

* maintenance: phpstorm analysis improvements

* tweak: remove data-element attribute

* tweak: check method or property of object
closes #489

* tweak: ignore caught error
g105b added a commit that referenced this issue Aug 12, 2024
@g105b
Bindable cache recursive (#496)
1db4484 
* build: upgrade dom requirement and loosen version range

* docs: update examples

* feature: trim whitespace when there are only template children
closes #363

* maintenance: phpstorm analysis improvements

* tweak: remove data-element attribute

* fix: bindable cache memory efficiency when using nested parent objects
fixes #495

* tweak: phpstan isset/empty check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Trim whitespace where there are only template children in an element PhpGt/DomTemplate
1 participant
@g105b