Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only build scsidump when building for the FULLSPEC board #1285

Closed
uweseimet opened this issue Nov 2, 2023 · 0 comments · Fixed by #1286
Closed

Only build scsidump when building for the FULLSPEC board #1285

uweseimet opened this issue Nov 2, 2023 · 0 comments · Fixed by #1286
Assignees
@uweseimet
Labels
enhancement New feature or request

Comments

@uweseimet
Copy link
Contributor

uweseimet commented Nov 2, 2023 •
edited
Loading

scsidump requires initiator mode, which is only supported by the FULLSPEC board. When compiling for the STANDARD board scsidump shall not be built.

In addition reset -Og to -O0 for debug builds. It has turned out that -Og omits some information.
@uweseimet uweseimet added the enhancement New feature or request label Nov 2, 2023
@uweseimet uweseimet self-assigned this Nov 2, 2023
@uweseimet uweseimet linked a pull request Nov 2, 2023 that will close this issue
Only build scsidump when building for the FULLSPEC board (#1285) #1286
Merged
uweseimet added a commit that referenced this issue Nov 7, 2023
@uweseimet
Only build scsidump when building for the FULLSPEC board (#1285) (#1286
616e11e 
)

* Only build scsidump when building for the FULLSPEC board

* Only install scsidump manpage when building for the FULLSPEC board

* Only install scsidump binary when building for the FULLSPEC board

* Revert debug optimization back to -O0, -Og omits some information
uweseimet added a commit that referenced this issue Nov 8, 2023
@uweseimet
Only build scsidump when building for the FULLSPEC board (#1285) (#1286
3856273 
)

* Only build scsidump when building for the FULLSPEC board

* Only install scsidump manpage when building for the FULLSPEC board

* Only install scsidump binary when building for the FULLSPEC board

* Revert debug optimization back to -O0, -Og omits some information
uweseimet added a commit that referenced this issue Nov 8, 2023
@uweseimet
Only build scsidump when building for the FULLSPEC board (#1285) (#1286
58660d8 
)

* Only build scsidump when building for the FULLSPEC board

* Only install scsidump manpage when building for the FULLSPEC board

* Only install scsidump binary when building for the FULLSPEC board

* Revert debug optimization back to -O0, -Og omits some information
uweseimet added a commit that referenced this issue Nov 8, 2023
@uweseimet
Only build scsidump when building for the FULLSPEC board (#1285) (#1286
d3ee8b6 
)

* Only build scsidump when building for the FULLSPEC board

* Only install scsidump manpage when building for the FULLSPEC board

* Only install scsidump binary when building for the FULLSPEC board

* Revert debug optimization back to -O0, -Og omits some information
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@uweseimet uweseimet

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only build scsidump when building for the FULLSPEC board (#1285) PiSCSI/piscsi
1 participant
@uweseimet