Remove SonarCloud cache setup as it is now offered by default #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to configure the cache anymore, SonarCloud now has an automatic analysis caching. See https://docs.sonarcloud.io/advanced-setup/languages/c-c-objective-c/#analysis-cache.
|
@mpaladin What would you say is the benefit with removing the explicit configuration? You never know when Sonar changes their default again, so being explicit doesn't hurt in my mind. |
@rdmark filesystem cache (the one which is currently used) was implemented several years ago, it required careful and manual configuration. We now implemented it as a default feature on SonarCloud, it won't be removed in the future, cache comes by default as we want it to be available to alls users to speed up the analysis without requiring manual configuration. |
rdmark
approved these changes
Apr 7, 2023
|
Thanks for the explanation! |
rdmark
pushed a commit
that referenced
this pull request
Apr 7, 2023
No need to configure the cache anymore, SonarCloud now has an automatic analysis caching. See https://docs.sonarcloud.io/advanced-setup/languages/c-c-objective-c/#analysis-cache.
akuker
added a commit
that referenced
this pull request
Apr 10, 2023
akuker
pushed a commit
that referenced
this pull request
Apr 10, 2023
…#1143) No need to configure the cache anymore, SonarCloud now has an automatic analysis caching. See https://docs.sonarcloud.io/advanced-setup/languages/c-c-objective-c/#analysis-cache. Co-authored-by: Massimo Paladin <massimo.paladin@gmail.com>
benjamink
pushed a commit
to benjamink/piscsi
that referenced
this pull request
Aug 10, 2023
…PiSCSI#1135)" (PiSCSI#1144) This reverts commit 3ad668c.
akuker
added a commit
that referenced
this pull request
Sep 2, 2023
* Update revision for release * Create sonarcloud.yml * Update sonarcloud.yml * Update sonarcloud.yml * Update sonarcloud.yml * Update sonarcloud.yml * Delete sonarcloud.yml * Update revision number for release * Remove SonarCloud cache setup as it is now offered by default (#1135) No need to configure the cache anymore, SonarCloud now has an automatic analysis caching. See https://docs.sonarcloud.io/advanced-setup/languages/c-c-objective-c/#analysis-cache. * Revert "Remove SonarCloud cache setup as it is now offered by default (#1135)" (#1144) This reverts commit 3ad668c. * Update web.yml * Update cpp.yml * Update web.yml * Update build_code.yml * Update build_code.yml * Update cpp.yml * Update web.yml --------- Co-authored-by: Tony Kuker <akuker@gmail.com> Co-authored-by: Massimo Paladin <massimo.paladin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to configure the cache anymore, SonarCloud now has an automatic analysis caching. See https://docs.sonarcloud.io/advanced-setup/languages/c-c-objective-c/#analysis-cache.