-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock werkzeug lib version to 2.3.7 #1234
Conversation
Here we have the issue where the docker container fails without proper error logging, again... :( @nucleogenic can you please remind me how to troubleshoot this? |
Hey @rdmark! Check the logs in the Github Action if you haven't already: They're under the 'Summary' tab: I'm seeing the following in
If that doesn't mean anything to you, or you think it's a Docker env specfic issue, give me a shout and I'll take a more in-depth look! |
3e389a8
to
d0eec3e
Compare
Found where the log is, thank you! I'll try to remember this for the next time. ;) The tests pass now so this is ready for your review. Please note that I'm living out of a hotel right now without access to my piscsi gear. So I have only tested as far as the web app launching (and then dying because the piscsi backend can't start up.) |
Hi folks, I'm glad this was resolved and closed, but this fix needs to be rolled into main and previous releases. None of the previous tags nor precompiled images work at this point. Every install will fail since the wrong version of werkzeug gets installed by default. |
Explicitly lock the werkzeug lib to v2.3.7 to avoid the issue where pip tries to pull a version that isn't compatible with Flask.
Also bumps Flask by one bugfix version.