Fix BSY pin handling in initiator mode #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uweseimet
changed the title
uweseimet
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
rdmark
approved these changes
Nov 13, 2023
|
@rdmark Yes, exactly. The initiator has to set BSY in particular for a proper arbitration/selection, but the original code did not configure the BSY pin as output pin when setting BSY in initiator mode. So BSY was affectively never set in initiator mode. The result was the target only seeing the initiator ID but not its own when there was arbitration before selection, which is what the SCSI standard requires. And when there is no target ID on the bus, no potential target will do anything. |
uweseimet
added a commit
that referenced
this pull request
Nov 13, 2023
uweseimet
added a commit
that referenced
this pull request
Nov 13, 2023
* In initiator mode configure BSY as an output pin when BSY is set
uweseimet
added a commit
that referenced
this pull request
Nov 13, 2023
* In initiator mode configure BSY as an output pin when BSY is set
uweseimet
added a commit
that referenced
this pull request
Nov 13, 2023
* In initiator mode configure BSY as an output pin when BSY is set
rdmark
pushed a commit
that referenced
this pull request
May 1, 2024
* In initiator mode configure BSY as an output pin when BSY is set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like #1284 this is another bug that must have always been there but has never been detected because usually initiator mode is not used. It's a pity, because I guess that none of the other SCSI solutions supports initiator mode.
Tested with the upcoming scsidump, which supports bus arbitration, which requires BSY to work.