Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fullspec/standard sub-folder #1324

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Remove fullspec/standard sub-folder #1324

merged 3 commits into from
Nov 14, 2023

Conversation

uweseimet
Copy link
Contributor

No description provided.

@uweseimet uweseimet linked an issue Nov 9, 2023 that may be closed by this pull request
@uweseimet
Copy link
Contributor Author

@rdmark I have a question related to expectation management ;-). There are currently 7 draft PRs targeting the release after the upcoming bookworm release. Except for #1323 there are only minimal changes, #1323 has the most changes, but it's essentially just moving code between classes.
Any idea when you might be able to review these tickets? There is currently a lot of testing going on. Regarding the daynaport I can now run most tests also on my hardware, and @benjamink is providing excellent help with testing on the Mac, not just related to the daynaport, but also other things. #1295 will provide us more means of partially automated testing. It contains a lot of code changes, though, but I have tried to extract some key changes into the existing small separate PRs.
All in all, I would not want to lose momentum. Merging all these changes into develop swiftly after the upcoming release would be very useful.

@uweseimet uweseimet marked this pull request as ready for review November 11, 2023 15:46
@rdmark
Copy link
Member

rdmark commented Nov 14, 2023

@uweseimet Regarding expectations, I’m on a business trip the whole week without a personal computer. I’m doing this code review on my iPhone right now.

Please be understanding with this being a hobby that we (most of us?) do for fun at our spare time. I enjoy reviewing your code but have limited spare time during the weeks…

At the same time I understand your eagerness to make progress with your refactoring and code quality improvements. Please bear with me as I work through these PRs.

@uweseimet
Copy link
Contributor Author

uweseimet commented Nov 14, 2023

@rdmark Sure, no problem. Note that the remaining ones are small, the device factory one was the biggest by far. When these are merged I will need time to merge the changes back into my current tickets anyway. What I mean to say is, that I do not expect that many PRs by me any time soon ;-).

@uweseimet uweseimet merged commit 7fa9abe into develop Nov 14, 2023
14 checks passed
@uweseimet uweseimet deleted the issue_1282 branch November 14, 2023 14:51
Copy link

sonarcloud bot commented Nov 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

uweseimet added a commit that referenced this pull request Nov 14, 2023
* Remove fullspec/standard sub-folder
uweseimet added a commit that referenced this pull request Nov 14, 2023
* Remove fullspec/standard sub-folder
uweseimet added a commit that referenced this pull request Nov 14, 2023
* Remove fullspec/standard sub-folder
uweseimet added a commit that referenced this pull request Nov 14, 2023
* Remove fullspec/standard sub-folder
rdmark pushed a commit that referenced this pull request May 1, 2024
* Remove fullspec/standard sub-folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove fullspec/standard sub-folder
2 participants