Use a standard timer for the DaynaPort delay work-around #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
rdmark
approved these changes
Nov 15, 2023
|
Just out of curiosity, how come this change is important? Standardizing the API used for timers? |
This change is important because, at least as far as I can tell right now, this was the only code location where I was not sure whether I can completely get rid of code using the special timer of the Raspberry Pi. If we do not need it it saves quite some code, and makes the code much more portable. |
uweseimet
added a commit
that referenced
this pull request
Nov 15, 2023
* Do not use the proprietary system timer for the DaynaPort delay work-around
uweseimet
added a commit
that referenced
this pull request
Nov 15, 2023
* Do not use the proprietary system timer for the DaynaPort delay work-around
6 tasks
rdmark
pushed a commit
that referenced
this pull request
May 1, 2024
* Do not use the proprietary system timer for the DaynaPort delay work-around
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A seemingly small change, but important. Tested with a Mac SE, but the actual delay does not change anyway with this change.