Fix typo (choice 0) in easyinstall.sh #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Frank Danapfel
benjamink
reviewed
Nov 17, 2023
easyinstall.sh
Outdated
| @@ -1504,7 +1504,7 @@ function readChoice() { | |||
| choice=-1 | |||
|
|
|||
| until [ $choice -ge "0" ] && ([ $choice -eq "99" ] || [ $choice -le "17" ]) ; do | |||
There was a problem hiding this comment.
Should this be changed to [ $choice -gt "0" ] ("greater than" rather than "greater than or equal to")?
There was a problem hiding this comment.
Good spot. I've just changed that to '-ge "1"'. The "99" choice is funny. It is called hidden, but everybody can see it when looking at the script ;-).
benjamink
approved these changes
Nov 17, 2023
rdmark
pushed a commit
that referenced
this pull request
May 1, 2024
* Fix typo (choice 0) in easyinstall.sh Co-authored-by: Frank Danapfel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Frank Danapfel frank.danapfel@redhat.com