Added ability to set the TYPE/CREATOR resource fork attributes of file(s) inside newly-created cd-rom ISO images of type HFS #1377
Conversation
…e(s) inside newly-created cd-rom ISO images of type HFS
… modified web.py to find it at that location
| # | ||
| # The mapping entries below are derived from | ||
| # https://github.com/Netatalk/netatalk/blob/branch-netatalk-2-3/config/AppleVolumes.system | ||
| # , which is under a GNU GPL license. |
There was a problem hiding this comment.
I think we can remove this particular line about GNU GPL, since it may imply the mapping entries fall under this license. The PiSCSI codebase is distributed under BSD-3-Clause.
python/web/src/web.py
Outdated
| # See more at https://linux.die.net/man/1/genisoimage | ||
| iso_args = ["-hfs", "-map", str(genisoimage_hfs_resource_fork_map_file_path)] | ||
| logging.info( | ||
| "Found and using the genisoimage hfs map file at %s .", |
There was a problem hiding this comment.
Nitpick: Why is there two spaces between %s and .? ;)
|
It's bizarre that the backend_tests job is failing here. I wonder if the permissions model changed for branches originating from forks...? |
|
Regrading |
|
Oh yes, that was it. Nice catch. I also ran a test from my own fork which passed: #1382 |
|
SonarCloud Quality Gate failed.
|
These days once I've locked down a changeset in a PR after a few roundtrips of changes, I like to sqash the commits in the PR branch locally and then force-push a "clean" commit (or commits). It helps avoid unwanted changes slipping through. |
…e(s) inside newly-created cd-rom ISO images of type HFS (#1377) * Added ability to set the TYPE/CREATOR resource fork attributes of file(s) inside newly-created cd-rom ISO images of type HFS * Added file genisoimage_hfs_resource_fork_map.txt under python/web and modified web.py to find it at that location
See #1376