Fix missing logging for a LUN when the LUN is explicitly specified #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
rdmark
reviewed
Nov 20, 2023
| @@ -39,16 +39,14 @@ void DeviceLogger::Error(const string& message) const | |||
|
|
|||
| void DeviceLogger::Log(level::level_enum level, const string& message) const | |||
| { | |||
| if (!message.empty() && | |||
There was a problem hiding this comment.
The !message.empty() check is not needed here?
There was a problem hiding this comment.
Inded, it is actually counter productive. When you ignore empty log messages you never notice that something with your logging is wrong. Because why would you intentially not log a message? This is very likely a bug, but you will not stumble upon it. If there is (with this change) a timestamp but no message you know that something is wrong with the code logging this message.
rdmark
approved these changes
Nov 26, 2023
rdmark
pushed a commit
that referenced
this pull request
May 1, 2024
…1379) * Fix missing logging for a LUN when the LUN is explicitly specified * Do not suppress controller messages when LUN is specified * Fix misleading logging for DaynaPort
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.