Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web UI: Use vsftpd webmin module #1396

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Web UI: Use vsftpd webmin module #1396

merged 1 commit into from
Dec 15, 2023

Conversation

rdmark
Copy link
Member

@rdmark rdmark commented Dec 10, 2023 •
edited
Loading

  • Install the vsftpd module when installing webmin with easyinstall.sh
  • Link to the module from the Web UI when webmin is installed

@rdmark rdmark requested a review from akuker as a code owner December 10, 2023 12:18
@rdmark rdmark requested a review from benjamink December 10, 2023 12:18
@rdmark rdmark mentioned this pull request Dec 10, 2023
Closed
@rdmark rdmark changed the title easyinstall: Install vsftpd webmin module Web UI: Use vsftpd webmin module Dec 11, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

benjamink
benjamink approved these changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@benjamink benjamink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave this a try on a clean v23.11.01 setup & it worked fine. 👍

@rdmark rdmark merged commit 24e60fa into develop Dec 15, 2023
11 of 12 checks passed
@rdmark rdmark deleted the rdmark-issue-1365 branch December 15, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamink benjamink benjamink approved these changes

@akuker akuker Awaiting requested review from akuker akuker is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rdmark @benjamink