Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize .cdr and .toast as CD-ROM image file endings #1413

Merged
merged 3 commits into from
Jan 26, 2024

Conversation

rdmark
Copy link
Member

@rdmark rdmark commented Jan 15, 2024

Proposing the addition of these two unambiguous file endings as recognized CD-ROM file endings (in addition to .iso and .is1)

Copy link

sonarcloud bot commented Jan 15, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rdmark
Copy link
Member Author

rdmark commented Jan 26, 2024

@nucleogenic Everyone else is on extended breaks from this project, so may I perhaps ask you to review this very trivial change? :)

Copy link
Member

@nucleogenic nucleogenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple but good QOL improvement, we should have done this ages ago! 👍

@rdmark
Copy link
Member Author

rdmark commented Jan 26, 2024

Cheers!

@rdmark rdmark merged commit 274b93f into develop Jan 26, 2024
14 of 15 checks passed
@rdmark rdmark deleted the rdmark-issue-1403 branch January 26, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants