Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure DiskCache constructor is called with a blocks count > 0 #1421

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Ensure DiskCache constructor is called with a blocks count > 0 #1421

merged 1 commit into from
Jan 18, 2024

Conversation

kkaempf
Copy link
Contributor

@kkaempf kkaempf commented Jan 17, 2024

otherwise its constructor assertion will fail when compile with DEBUG=1

Fixes #1418

@kkaempf
DiskCache needs a size
dbc986b 
otherwise its constructor assertion (block > 0) will fail.

Fixes PiSCSI#1418

Signed-off-by: Klaus Kämpf <kkaempf@gmail.com>
@kkaempf kkaempf requested review from akuker and rdmark as code owners January 17, 2024 13:21
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 17, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rdmark rdmark merged commit 7cc8df2 into PiSCSI:develop Jan 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdmark rdmark rdmark approved these changes

@akuker akuker Awaiting requested review from akuker akuker is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkaempf @rdmark