Use font metrics instead of fixed with calculations in text.py and textpos.py #142
Conversation
Modified text.py and textpos.py to use font metrics instead of fixed width calculations. So non fixed width fonts (e.g. FreeSans) work as expected. In textpos.py do not display lines which are off the bottom of the screen.
| text_lines[current_line] += " " + word | ||
| else: | ||
| # No space left on line so move to next one | ||
| text_lines.append("") | ||
| text_lines.append(u"") | ||
| current_line += 1 | ||
| text_lines[current_line] += " " + word |
There was a problem hiding this comment.
I believe this should be: text_lines[current_line] += word There is no need to add the space before as you have incremented the line.
| else: | ||
| # No space left on line so move to next one | ||
| text_lines.append("") | ||
| text_lines.append(u"") | ||
| current_line += 1 | ||
| text_lines[current_line] += " " + word |
There was a problem hiding this comment.
I believe this should be: text_lines[current_line] += word There is no need to add the space before as you have incremented the line.
There was a problem hiding this comment.
The original code had the leading space on continuation lines when the text autowraps, so I just left it.
If you do not want the leading space, you can include a new-line ('\n') character in the string for AddText, i.e: 'Text line 1\nText line 2'
|
@tvoverbeek I didn't follow this too closely so if you are OK with these changes you can merge yourself |
|
Thanks @tvoverbeek |
Modified text.py and textpos.py to use font metrics instead of fixed
width calculations.
So non fixed width fonts (e.g. FreeSans) work as expected.
In textpos.py do not display lines which are off the bottom of the
screen.