Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test code from papirus-draw #149

Merged
merged 1 commit into from
Aug 24, 2017
Merged

Conversation

GekoPrime
Copy link
Contributor

papirus-draw now draws the image only once.

Previously the image was drawn five times: once at each rotation, and finally at the requested rotation

papirus-draw now draws the image only once.

Previously the image was drawn five times:
once at each rotation, and finally at the requested rotation
@tvoverbeek
Copy link
Contributor

tvoverbeek commented Aug 24, 2017

It is intended as demo code to show the effects of all rotation angles, hence the five times.
Before the rotation argument was added we had the single draw image (as in your PR).

@shawaj
Copy link
Member

shawaj commented Aug 24, 2017

@tvoverbeek papirus draw was originally intended to be a "functional" bit of code to allow people to put images on screen from command line.

Is that not the case anymore?

In readme it has:

# Draw image on the screen
papirus-draw /path/to/image -t [resize | crop] -r [0 | 90 | 180 | 270]

@tvoverbeek
Copy link
Contributor

@shawaj OK, I accept the "functional" part and will merge this.

@tvoverbeek tvoverbeek merged commit 6a37c7b into PiSupply:master Aug 24, 2017
@shawaj
Copy link
Member

shawaj commented Sep 18, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants