Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update missing dependencies #151

Merged
merged 3 commits into from
Jan 4, 2018

Conversation

erickeller
Copy link
Contributor

make and gcc is required for building some code at installation time.

make and gcc is required for building some code at installation time.
@shawaj
Copy link
Member

shawaj commented Sep 8, 2017

What system have you seen an error on? On Raspbian it seems to build just fine

@tvoverbeek
Copy link
Contributor

Both Raspbian-full and Raspbian-lite already have make, gcc and whiptail installed.
So no need to add them to the dependencies, unless you are running on some other OS

@erickeller
Copy link
Contributor Author

erickeller commented Sep 8, 2017 via email

@shawaj
Copy link
Member

shawaj commented Sep 8, 2017

@erickeller yeah agreed there's no harm in adding them in

@erickeller
Copy link
Contributor Author

if there are other dependencies please also add them into.
what would also be nice to have is one file containing the dependencies (single source of truth) you include in your readme but for this I thin you need to move to the rst format.

Even better would be to move to a debian package :)
Anyway I was able to use my nice papirus e-ink afterall, thanks for the good work.

@shawaj
Copy link
Member

shawaj commented Jan 3, 2018

@tvoverbeek @francesco-vannini what do we think to this?

@tvoverbeek
Copy link
Contributor

My original problem was that every call to apt-get scans the package database which takes time.
Therefore I was sceptic to add additional apt-get calls.
However combining aa many as possible required packages in a single apt-get call scans the database only once.
Therefore no problem any more and merged

@tvoverbeek tvoverbeek merged commit d86f65a into PiSupply:master Jan 4, 2018
@shawaj
Copy link
Member

shawaj commented Jan 4, 2018

Perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants