Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor typo and wording fixes in README #178

Merged
merged 2 commits into from
Mar 12, 2018
Merged

Minor typo and wording fixes in README #178

merged 2 commits into from
Mar 12, 2018

Conversation

VirtualWolf
Copy link
Contributor

Just some very tiny fixes.

@shawaj
Copy link
Member

shawaj commented Feb 11, 2018

Thanks! Mostly look ok but line 339 and 340 doesn't look complete?

@shawaj
Copy link
Member

shawaj commented Feb 11, 2018

Also noticed that PaPiRus is capitalised incorrectly in a few places...

@VirtualWolf
Copy link
Contributor Author

Thanks! Mostly look ok but line 339 and 340 doesn't look complete?

Hm, yeah, it could be improved... I assume the library will always just show the images in filename order, right? And it's just if you have an animation you need to name them in some sort of sequence where they'll be read in the right order (be it 0.gif, 1.gif, 2.gif or a.gif, b.gif, c.gif)?

Also noticed that PaPiRus is capitalised incorrectly in a few places...

Ah, good catch. It was tricky picking them out in between the places in the code examples where it's meant to be just "Paprius", heh.

@shawaj
Copy link
Member

shawaj commented Feb 12, 2018

Yeah I'll correct those later.

About the mine 339 and 340 it was more that there was some text removed that shouldn't have been.

Just wondered if this was intentional and if so, then why?

@francesco-vannini
Copy link
Contributor

PaPiRus animation can also be used as a slide show without any specific order for the pictures and with a few more picture formats allowed. The original description can be found in c93ecce

 # Display image sequences or slide-show
 +The path containing the pictures must have number sequenced images in the form 1.gif, 2.gif, 3.gif, etc. for an animation or pictures with random names (e.g. in the case of a slide-show). 
  papirus-animation path [rotation] [delay] [fullupdate] [loop]

@VirtualWolf
Copy link
Contributor Author

Just wondered if this was intentional and if so, then why?

Trying to make things a bit less wordy and clearer. :) I've updated it again, and fixed the Paprirus -> PaPiRus as well.

@tvoverbeek tvoverbeek merged commit 595c303 into PiSupply:master Mar 12, 2018
@tvoverbeek
Copy link
Contributor

@VirtualWolf Thanks for the corrections. Apologies for the delay in merging.

@VirtualWolf
Copy link
Contributor Author

No worries, cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants