Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

papirus-write complained about missing parentheses #67

Merged
merged 2 commits into from
Jan 21, 2017

Conversation

CleoQc
Copy link

@CleoQc CleoQc commented Dec 29, 2016

It wouldn't run without this change, tested on a brand new Raspbian card

@francesco-vannini
Copy link
Contributor

Hi Cleo, isn't it because you are using Python 3 that you get that?

@CleoQc
Copy link
Author

CleoQc commented Dec 30, 2016

Hi @francesco-vannini, fancy meeting you here :)
Nope I'm using Python 2. In fact, it's on a fresh Jessie (from Nov 25th), so SD card is not dirty.
When I type python, I do get python 2.
When I run python papirus-write, it complains and crashes
When I run the one in /usr/local/bin on its own, it complains and crashes.
Looks like you're pulling from future import print_function from somewhere but I didn't investigate that.

@shawaj
Copy link
Member

shawaj commented Jan 3, 2017

Strange - never seen that error before. How odd.

I have an old version sat on my desk with software already installed - will test with that.

@francesco-vannini have you tested with a new Raspbian as well?

If it works on both fine, then no reason to not add the ()

@CleoQc
Copy link
Author

CleoQc commented Jan 18, 2017

Also those files already use the parentheses for the print statements as this link shows:
https://github.com/PiSupply/PaPiRus/search?utf8=%E2%9C%93&q=print

So right now it's inconsistent the way it's currently done.

Copy link
Contributor

@francesco-vannini francesco-vannini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed this bring the code in line with the rest and helps for Python 3 compatibility

@francesco-vannini francesco-vannini merged commit ea3e968 into PiSupply:master Jan 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants