Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After Ctrl + Alt + U,All show "Uploading..." #34

Closed
CatcherX opened this issue Apr 19, 2019 · 26 comments
Closed

After Ctrl + Alt + U,All show "Uploading..." #34

CatcherX opened this issue Apr 19, 2019 · 26 comments
Labels
bug Something isn't working upstream

Comments

@CatcherX
Copy link

Version: 1.33.1 (user setup)
Commit: 51b0b28134d51361cf996d2f0a1c698247aeabd8
Date: 2019-04-11T08:27:14.102Z
Electron: 3.1.6
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 6.1.7601

PicGo:2.0.3

@Spades-S
Copy link
Member

@CatcherX Upload successfully when select sm.ms as the image hoisting service. Emmm.... maybe the network is very bad. Can you add more info, such as settings...

Kapture 2019-04-19 at 18 20 57

@CatcherX
Copy link
Author

My network is normal. Uploading images from explorer is very fast.But uploading an image from clipboard is all show uploading, the log file not not recorded.

@upupming
Copy link
Member

Please show your log in vscode. and seetings.json

@upupming
Copy link
Member

@CatcherX Just a reminder, you can see your vscode console by click Help -> Toggle Developer Tools and you should see something like this:

image

You settings.json can be opened by File -> Preference -> Settings or Ctrl + ,.

Please copy error logged at the console and your setttings.json here.

@Spades-S We probably should update the issue template!

@CatcherX
Copy link
Author

@CatcherX Just a reminder, you can see your vscode console by click Help -> Toggle Developer Tools and you should see something like this:

image

You settings.json can be opened by File -> Preference -> Settings or Ctrl + ,.

Please copy error logged at the console and your setttings.json here.

@Spades-S We probably should update the issue template!

ERR spawn powershell ENOENT: Error: spawn powershell ENOENT at Process.ChildProcess._handle.onexit (internal/child_process.js:229:19) at onErrorNT (internal/child_process.js:406:16) at process._tickCallback (internal/process/next_tick.js:63:19)

@Molunerfinn
Copy link
Member

@CatcherX Open your cmd and write powershell, enter,take a screenshot.

@Molunerfinn
Copy link
Member

Molunerfinn commented Apr 19, 2019

It may be the same issue as this one, checkout if powershell is in your system PATH.

image

@Spades-S
Copy link
Member

@CatcherX Just a reminder, you can see your vscode console by click Help -> Toggle Developer Tools and you should see something like this:

image

You settings.json can be opened by File -> Preference -> Settings or Ctrl + ,.

Please copy error logged at the console and your setttings.json here.

@Spades-S We probably should update the issue template!

Yeah, urgent!

@CatcherX
Copy link
Author

It may be the same issue as this one, checkout if powershell is in your system PATH.

image

After put the powershell in system PATH,try again,show:

2019-4-19-19-28-25_11.jpg

@CatcherX
Copy link
Author

CatcherX commented Apr 19, 2019

{
"workbench.colorTheme": "Visual Studio Dark",
"git.autofetch": true,
"picgo.picBed.github.path": "/",
"picgo.customUploadName": "${dateTime}_${fileName}${extName}",
"picgo.configPath": "D:\PicGo\bed.json",
"http.proxy": ""
}

2019-4-19-19-33-31_config.jpg

@Molunerfinn
Copy link
Member

What's your system path? take shot

@CatcherX
Copy link
Author

CatcherX commented Apr 19, 2019

2019-4-19-19-44-2_path.jpg
C:\Users\Administrator\AppData\Local\Programs\Fiddler;C:\Users\Administrator\AppData\Roaming\npm;C:\Users\Administrator\AppData\Local\Programs\Microsoft VS Code\bin;C:\Windows\System32\WindowsPowerShell\v1.0\

@Spades-S
Copy link
Member

Spades-S commented Apr 19, 2019

@CatcherX The config path is WRONG!
image
The right is D:\\Picgo\\bed.json

@CatcherX
Copy link
Author

2019-4-19-19-52-40_cccc.jpg

The right is D:\\Picgo\\bed.json

I am sorry.That is after escape,Actually, it's right.

@Molunerfinn
Copy link
Member

If you are using Win7, you can just upload clipboard with image content, not the image file itself.

如果你在使用Win7,由于powershell版本的限制,你要上传剪贴板图片是有条件的。比如你不能复制一个「图片文件」然后上传,你只能复制「图片内容」,这样才能通过PicGo的剪贴板上传。什么叫「图片内容」?比如你用QQ截图,这个时候截图是以图片内容的形式存放在剪贴板里;你在网页上右键一张图片,选择「复制图片」的时候,是以图片内容的形式存放在剪贴板里。但是你要是在系统里右键一张图片文件,然后选择复制,这样是以「图片文件」的形式存放在剪贴板里的,PicGo在Win7的里是不支持这种形式上传的。

@Molunerfinn
Copy link
Member

You can try this:

  1. reboot your PC
  2. open VSCode
  3. take a screenshot
  4. upload with vs-picgo by uploading with clipboard

Let's see what will happen

@CatcherX
Copy link
Author

CatcherX commented Apr 19, 2019

2019-4-19-20-9-30_888.jpg
2019-4-19-20-10-26_111.jpg

已经重启过计算机,这是截图,然后从剪切板粘贴(Ctrl+Alt+U),
在我的配置文件目录,能看到我截图的文件。

@Molunerfinn
Copy link
Member

嗯大概知道是哪里的问题了。不过没有Win7的系统没有办法深入测试...

@Molunerfinn
Copy link
Member

目前的问题大概是PicGo从剪贴板里通过Powershell生成了图片之后,powershell返回的图片路径为空,导致上传的时候传给PicGo的路径是'',就上传失败。

@Molunerfinn
Copy link
Member

If you use vs-picgo's default config instead of yourself config file, what will happen

@upupming
Copy link
Member

upupming commented Apr 19, 2019

{
"workbench.colorTheme": "Visual Studio Dark",
"git.autofetch": true,
"picgo.picBed.github.path": "/",
"picgo.customUploadName": "${dateTime}_${fileName}${extName}",
"picgo.configPath": "D:\PicGo\bed.json",
"http.proxy": ""
}

2019-4-19-19-33-31_config.jpg

You are mixing the style of the configuration of v1.x and v2.0. Please delete all the picgo and picBed object, and only keep something like these is okay:

// ...
"picgo.configPath": "C:\\Users\\Doraeming\\AppData\\Roaming\\PicGo\\data.json",
"picgo.customUploadName": "${fileName}-${dateTime}",
"picgo.customOutputFormat": "<img src=\"${url}\" alt=\"${uploadedName}\">",
// ...

And also you can delete all the configuration of picgo, and it will be okay since vs-picgo will fall back to sm.ms default settings.

@Molunerfinn
Copy link
Member

@CatcherX ctrl+alt+o is the upload from the input box, you should use ctrl+alt+u to upload the clipboard files!

image

@CatcherX
Copy link
Author

CatcherX commented Apr 19, 2019

@upupming
@Molunerfinn
2.jpg
222.jpg
333333333.jpg

I'm trying again on another computer.Use the default settings.
The mistake is still like this.

@CatcherX CatcherX changed the title After Ctrl + Alt + O,All show "Uploading..." After Ctrl + Alt + U,All show "Uploading..." Apr 19, 2019
@upupming
Copy link
Member

upupming commented Apr 19, 2019

Thanks for the report, @Spades-S is investigating it now. We will try to fix it ASAP.

@upupming upupming added bug Something isn't working upstream and removed needs more info labels Apr 19, 2019
@Molunerfinn
Copy link
Member

PicGo-Core v1.3.6 fix this bug

Spades-S added a commit that referenced this issue Apr 21, 2019
* 📦 Chore: add bump version (#32)

* 📦 Chore: add picgo bump version

* 📦 Chore: substitute npm with yarn

* 📦 Chore: move pre-commit to husky for using by `git cz`

* 📦 Chore: finish azure pipeline & remove appveyor

* 🔙 Revert: fix mistake in test script

* 📝 Docs: make readme tidier

* 📝 Docs: revert to details/summary tags

* 📝 Docs: update license

* 📝 Docs: add upupming to license

* 📝 Docs: currect azure project name (#33)

* ⬆️ Upgrade: picgo to 1.3.6

fix bugs when upload images from clipboard in Windows 7

ISSUES CLOSED: #34

* 🎉 Release: 2.0.4
@Spades-S
Copy link
Member

@CatcherX Fixed in vs-picgo 2.0.4. Please upgrade vs-picgo

Spades-S added a commit that referenced this issue Jul 26, 2021
* 📦 Chore: add bump version (#32)

* 📦 Chore: add picgo bump version

* 📦 Chore: substitute npm with yarn

* 📦 Chore: move pre-commit to husky for using by `git cz`

* 📦 Chore: finish azure pipeline & remove appveyor

* 🔙 Revert: fix mistake in test script

* 📝 Docs: make readme tidier

* 📝 Docs: revert to details/summary tags

* 📝 Docs: update license

* 📝 Docs: add upupming to license

* 📝 Docs: currect azure project name (#33)

* ⬆️ Upgrade: picgo to 1.3.6

fix bugs when upload images from clipboard in Windows 7

ISSUES CLOSED: #34

* 🎉 Release: 2.0.4

* 🐛 Fix: add tencent cos path option

* 🔨 Refactor: code structure, message consistency, fix settings changing issue, out-of-box format(#36)

* 🔨 Refactor: code structure

* 🐛 Fix: picgo -> vspicgo, prettier fix

* 🐛 Fix: on load -> before upload plugin

* 🎨 Style: log -> data

* 🐛 Fix: get config, editor each time

* 🎨 Style: message consistency

* 🐛 Fix: qiniu.area enum -> string

* 🐛 Fix: update picgo on settings changed

* ✨ Feature: out-of-box format

* 🔙 Revert: still using enum for qiniu area

* 🔨 Refactor: singleton pattern for `picgo`

* 🐛 Fix: add tencent cos path option

* 🔨 Refactor: replace require with fs

* 📝 Docs: readme.md

add summary tag in details tag aimed at PicGo-electorn users

* 📝 Docs: fix custom upload name & custom output format docs

* 📝 Docs: update issue templates

* 📝 Docs: code format

* ✅ Test: add basic testes (#42)

* ✅ Test: add basic testes

* 🐛 Fix: import -> require

* 🐛 Fix: build

* 📦 Chore: add coveralls env

* ✨ Feature: test report on command line

* Update package.json

* 🐛 Fix: coverage

* ✨ Feature: report to coveralls

* 🐛 Fix: use sed to fix lcov.info's relative path

* ⬆️ Upgrade: fix querystringify vulnerability

* 🐛 Fix: azure pipeline + coveralls

see
https://github.com/dylan-smith/node-coveralls/blob/10e327653aa0f2f382efee3af800beae0aabaac5/lib/getOptions.js

* 📦 Chore: azure -> github actions

* ✨ Feature(package.json): support sm.ms V2

upgrade dependencies, support sm.ms V2

ISSUES CLOSED: #57

* 📦 Chore: replace tslint with eslint

* 📦 Chore(.vscode): update .vscode

* 🎨 Style: run codestyle:fix

* 📝 Docs: update docs: README.md, CHANGELOG.md

* 📝 Docs: update README.md

* ✅ Test(test): refactor unit tests

* 📦 Chore: add coverage collector

* build(deps): bump lodash from 4.17.15 to 4.17.19 (#68)

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.15...4.17.19)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump decompress from 4.2.0 to 4.2.1 (#71)

Bumps [decompress](https://github.com/kevva/decompress) from 4.2.0 to 4.2.1.
- [Release notes](https://github.com/kevva/decompress/releases)
- [Commits](kevva/decompress@v4.2.0...v4.2.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump ini from 1.3.5 to 1.3.7 (#73)

Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.7.
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](npm/ini@v1.3.5...v1.3.7)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: 🎸 add support for svg (#74)

add support for svg image while choosing files

* 🐛 Fix(ci): github actions use yarn to lock versions (#77)

* 🐛 Fix(clipboard): set `PICGO_ENV` to `CLI`, fixes #75 (#78)

* 🐛 Fix(clipboard): set `PICGO_ENV` to `CLI`, fixes #75

also update picgo core
add failed message

* 🐛 Fix(version): 2.0.4 -> 2.1.0

* 📦 Chore(deps): update deps

* 📦 Chore(bundle): add webpack

* 🐛 Fix(proxy): add proxy config, fixes #79

* ⬆️ Upgrade: update picgo core

* 📦 Chore: migrate to standardjs (#83)

* 🚧 WIP(code style): migrate to standardjs

* 🐛 Fix(upload): upload events off

* ✅ Test: fix test configuration

* 📦 Chore: add console for message

* 🐛 Fix: show message should not block following operations

* ⬆️ Upgrade(core): upgrade dependencies (#92)

Co-authored-by: Yiming Li <yimingli.cs@gmail.com>

* 🎉 Release: v2.1.1

* 🐛 Fix(dep): bundle picgo-core to dist

* 🎉 Release: v2.1.2

Co-authored-by: Li Yiming <upupming@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: kkyeer <kkyeer@gmail.com>
Co-authored-by: Yiming Li <yimingli.cs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream
Projects
None yet
Development

No branches or pull requests

4 participants