Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming convention between 2F-85 and 2F-140 different #66

Open
karanchahal opened this issue Sep 26, 2024 · 2 comments
Open

Naming convention between 2F-85 and 2F-140 different #66

karanchahal opened this issue Sep 26, 2024 · 2 comments

Comments

@karanchahal
Copy link

Hello,

We are trying to use this package for both 2F-140 and 2F-85 URDF files, but we notice that the naming convention is very different for the link names between the two.

Why is this the case and can we unify them ?
@JafarAbdi
Copy link
Contributor

Why is this the case and can we unify them ?

We just used the names from the original repos, there is no other reason as far as I know, I'll be happy to review a PR to unify them!

@karanchahal karanchahal mentioned this issue Sep 26, 2024
Closed
@karanchahal
Copy link
Author

Done, can you review it ? Let me know where to make changes, happy to push this through

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unify 2F_85 and 2F_140 link names karanchahal/ros2_robotiq_gripper
2 participants
@karanchahal @JafarAbdi