Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update step-security/harden-runner configuration #1177

Merged
merged 2 commits into from
May 19, 2024

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented May 16, 2024

Suggested commit message:

Update `step-security/harden-runner` configuration (#1177)

This resolves recent build failures by ensuring that JDKs can be
downloaded.

@Stephan202 Stephan202 added this to the 0.17.0 milestone May 16, 2024
@Stephan202 Stephan202 changed the title Allow more build steps to access api.adoptium.net Update step-security/harden-runner configuration May 16, 2024
@Stephan202
Copy link
Member Author

I force-pushed a change, but it's not showing up here yet 👀.

This resolves recent build failures by ensuring that JDKs can be
downloaded.
@Stephan202 Stephan202 force-pushed the sschroevers/fix-build branch 2 times, most recently from 2c5c537 to 8a03c76 Compare May 16, 2024 04:48
@Stephan202
Copy link
Member Author

Still connection issues; I wonder whether this is a GitHub issue. Will check back later.

github.com:443
jitpack.io:443
objects.githubusercontent.com:433

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed the port number should be 443, but is currently being set to 433 which is causing the outbound call to get blocked.

github.com:443
objects.githubusercontent.com:433

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, the port should be 443

api.github.com:443
github.com:443
objects.githubusercontent.com:433

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, the port should be 443

checkstyle.org:443
github.com:443
objects.githubusercontent.com:433

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, the port should be 443

ea6ne4j2sb.execute-api.eu-central-1.amazonaws.com:443
github.com:443
objects.githubusercontent.com:433

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, the port should be 443

@Stephan202
Copy link
Member Author

Tnx @varunsh-coder! Thanks for pointing out my silly mistake. A+ support. 💪 ❤️

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@varunsh-coder
Copy link

Tnx @varunsh-coder! Thanks for pointing out my silly mistake. A+ support. 💪 ❤️

No problem, feel free to tag me on GitHub or reach out to support@stepsecurity.io in case you have any questions or feedback.

Copy link
Contributor

@mohamedsamehsalah mohamedsamehsalah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔓

@Stephan202 Stephan202 merged commit 8a82905 into master May 19, 2024
14 checks passed
@Stephan202 Stephan202 deleted the sschroevers/fix-build branch May 19, 2024 12:14
@Stephan202 Stephan202 added the chore A task not related to code (build, formatting, process, ...) label May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A task not related to code (build, formatting, process, ...)
Development

Successfully merging this pull request may close these issues.

4 participants