Upgrade JDKs used by GitHub Actions builds

[Stephan202]

Suggested commit message:

Upgrade JDKs used by GitHub Actions builds (#1329)

Summary of changes:
- Use JDK 17.0.13 instead of 17.0.10.
- Use JDK 21.0.5 instead of 21.0.2.
- Use JDK 23.0.1 instead of 22.0.2.
- Have GitHub issue template reference more recent version numbers.

See:
- https://adoptium.net/temurin/release-notes/?version=jdk-17.0.11+9
- https://adoptium.net/temurin/release-notes/?version=jdk-17.0.12+7
- https://adoptium.net/temurin/release-notes/?version=jdk-17.0.13+11
- https://adoptium.net/temurin/release-notes/?version=jdk-21.0.3+9
- https://adoptium.net/temurin/release-notes/?version=jdk-21.0.4+7
- https://adoptium.net/temurin/release-notes/?version=jdk-21.0.5+11
- https://adoptium.net/temurin/release-notes/?version=jdk-23+37
- https://adoptium.net/temurin/release-notes/?version=jdk-23.0.1+11

[github-actions]

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

[Stephan202]

I would have expected an Error Prone incompatibility, but in fact it's an OpenRewrite incompatibility 😅. @timtebeek FYI:

Caused by: java.lang.NoSuchMethodError: 'com.sun.tools.javac.tree.DCTree$DCDocComment com.sun.tools.javac.tree.DocCommentTable.getCommentTree(com.sun.tools.javac.tree.JCTree)'
	at org.openrewrite.java.isolated.ReloadableJava11ParserVisitor.convert(ReloadableJava11ParserVisitor.java:1590)

JDK 23 will be released later this month, so perhaps worth looking into. (My schedule is packed the coming weeks, so unfortunately I won't have time to dive in myself.)

[timtebeek]

JDK 23 will be released later this month, so perhaps worth looking into. (My schedule is packed the coming weeks, so unfortunately I won't have time to dive in myself.)

Understandable; the usage is here indeed (and in the Java 8/11/17 parser visitors): https://github.com/openrewrite/rewrite/blob/a98d83d698dda9971c93a0767b7f85d5866f306d/rewrite-java-21/src/main/java/org/openrewrite/java/isolated/ReloadableJava21ParserVisitor.java#L1666

Adding some links for context:

• https://jdk.java.net/23/release-notes
• https://openjdk.org/jeps/467

Can't immediately find any public mention of the changes to DocCommentTable, so it seems we'd need to install 23-ea to explore further and see what's available. Annoying that SDKman doesn't yet list a 23-ea release. 🤔

/cc @knutwannheden

As an aside you might want to change these lines to use rewrite-java-17, or a version matching the runtime Java version, as you're right now getting an error from our Java 11 parser, but a fix is likely to land in a newer parser version instead.

error-prone-support/error-prone-contrib/pom.xml

Lines 202 to 206 in 9f222e9

	<dependency>
	<groupId>org.openrewrite</groupId>
	<artifactId>rewrite-java-11</artifactId>
	<scope>test</scope>
	</dependency>

[Stephan202]

As an aside you might want to change these lines to use rewrite-java-17, or a version matching the runtime Java version, as you're right now getting an error from our Java 11 parser, but a fix is likely to land in a newer parser version instead.

Ack! I filed #1330.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

[timtebeek]

• Now also tracked at: OpenRewrite fails to parse java files when using Java 23 openrewrite/rewrite#4513

• And likely fixed in Accommodate Java 23 in ReloadableJava21ParserVisitor openrewrite/rewrite#4516

We'll do another release this Wednesday; should help to see if this worked. :)

[github-actions]

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

[github-actions]

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

[Stephan202]

Updated the PR; build should pass once openrewrite/rewrite#4618 is released.

[timtebeek]

Updated the PR; build should pass once openrewrite/rewrite#4618 is released.

I've just released https://github.com/openrewrite/rewrite/releases/tag/v8.38.1 ;
That's on top of yesterday's https://github.com/openrewrite/rewrite-templating/releases/tag/v1.16.3
Do let me know how those work out for you!

[Stephan202]

Nice! I expect Renovate to open the upgrade PR tonight. 🌚

[Stephan202]

Nice! I expect Renovate to open the upgrade PR tonight. 🌚

Nope, cause we pull it in via rewrite-recipe-bom, for which no release happened yet. For now I added an upgrade commit to this branch; to be dropped again later. Build should now pass.... 👀

[github-actions]

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

[mohamedsamehsalah]

📈 📈 📈

[rickie]

Let's bump to 0.19.0 already? As we are gonna release that soon :).

[rickie]

Nice to see the fixes @timtebeek 🚀 !

[github-actions]

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

[github-actions]

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

[github-actions]

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[timtebeek]

Thanks all! Great to see the fix land here; we release OpenRewrite every two weeks, with the next one the day before JFall to remove the temporary override added here.